Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an extra method to (Checked)Euclid trait to get both quotien and rem #291

Merged
merged 4 commits into from Oct 25, 2023

Conversation

tdelabro
Copy link
Contributor

closes #290

Copy link
Member

@cuviper cuviper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested some fixes for the documentation. I would also appreciate some tests, and doc-examples are an easy way to both demonstrate the feature and test it.

I think we should drop "with" from the name, just div_rem_euclid and checked_div_rem_euclid. This will be more similar to Integer::div_rem.

src/ops/euclid.rs Outdated Show resolved Hide resolved
src/ops/euclid.rs Outdated Show resolved Hide resolved
src/ops/euclid.rs Outdated Show resolved Hide resolved
src/ops/euclid.rs Outdated Show resolved Hide resolved
@tdelabro tdelabro requested a review from cuviper October 13, 2023 10:44
@tdelabro
Copy link
Contributor Author

@cuviper it's ready for another review

src/ops/euclid.rs Outdated Show resolved Hide resolved
@tdelabro tdelabro requested a review from cuviper October 23, 2023 08:57
@tdelabro
Copy link
Contributor Author

@cuviper Ready for review

src/ops/euclid.rs Outdated Show resolved Hide resolved
@cuviper
Copy link
Member

cuviper commented Oct 25, 2023

Thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 25, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit f832428 into rust-num:master Oct 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add a quotien_and_rem_euclid method to Euclid trait
2 participants