Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide nicer parse errors and suggest "full-syntax" #39

Merged
merged 2 commits into from Jul 29, 2020

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Jul 27, 2020

The included compile_fail test has this output:

error: expected `,`
  --> src/test.rs:13:24
   |
10 |     VarA = get_an_isize!(), // error without "syn/full"
   |                        ^

error: this might need the "full-syntax" feature of `num-derive`
 --> src/test.rs:11:10
  |
8 | #[derive(num_derive::FromPrimitive)]
  |          ^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: this error originates in a derive macro (in Nightly builds, run with -Z macro-backtrace for more info)

Closes #16.

@cuviper
Copy link
Member Author

cuviper commented Jul 29, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 29, 2020

@bors bors bot merged commit 77c551f into rust-num:master Jul 29, 2020
@cuviper cuviper deleted the parse-errors branch July 5, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

derives panic when a discriminant is given by a macro
1 participant