Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update syn related dependencies to 1.0 and bump version #28

Merged
merged 6 commits into from Aug 15, 2019
Merged

Update syn related dependencies to 1.0 and bump version #28

merged 6 commits into from Aug 15, 2019

Conversation

Eijebong
Copy link
Contributor

No description provided.

@cuviper
Copy link
Member

cuviper commented Aug 15, 2019

Thanks for the PR. I want to treat this as a breaking change, since it increases the MSRV. Can you make it 0.3.0, and also update the CI config?

@Eijebong
Copy link
Contributor Author

Sure, done 👍

@cuviper
Copy link
Member

cuviper commented Aug 15, 2019

Thanks -- I've pushed a few version-related tweaks of my own. I'll probably update to 2018 edition too, but I'll stop abusing your PR for this... 😉

bors r+

bors bot added a commit that referenced this pull request Aug 15, 2019
@bors @Eijebong @cuviper
Merge #28
d0a92ae 
28: Update syn related dependencies to 1.0 and bump version r=cuviper a=Eijebong



Co-authored-by: Bastien Orivel <eijebong@bananium.fr>
Co-authored-by: Josh Stone <cuviper@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 15, 2019

Build succeeded

@bors bors bot merged commit d93f537 into rust-num:master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Eijebong @cuviper