Add Socket::peek_sender()
#389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonander
force-pushed
the
ab/peek-sender
branch
from
1d5e20f
to
39f1a06
Compare
abonander
commented
Feb 24, 2023
abonander
commented
Feb 24, 2023
abonander
force-pushed
the
ab/peek-sender
branch
from
39f1a06
to
a721554
Compare
abonander
force-pushed
the
ab/peek-sender
branch
2 times, most recently
from
0f4d659
to
14ccde1
Compare
Signed-off-by: Austin Bonander <austin@launchbadge.com>
abonander
force-pushed
the
ab/peek-sender
branch
from
14ccde1
to
f202842
Compare
Thomasdezeeuw
approved these changes
Feb 24, 2023
|
Thanks @abonander |
|
@Thomasdezeeuw do you know roughly how long until 0.5 is released? I could also put in a PR to backport this if you like. |
Don't really have an ETA, but I think the TODO list is shrinking. I'll see if I can release it this weekend, otherwise we can backport. |
|
The MSRV bump in 0.5 is unfortunately unacceptable for Tokio so it looks like I'll be backporting this anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: tokio-rs/tokio#5491