Use indicatif as the progress bar #3349
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi-rustin
force-pushed
the
rustin-patch-indicatif
branch
2 times, most recently
from
44ef07c
to
9efea91
Compare
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
hi-rustin
force-pushed
the
rustin-patch-indicatif
branch
from
9efea91
to
3572f82
Compare
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
|
I can confirm this resolves the issue for me on FreeBSD + xterm[-256color]. My symptoms were identical to #1826 even though that was reported for a different environment (Alacritty + ConPTY) |
|
This PR will cause some display issues when changing the window size of the terminal. So I am going to close it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2828
Close #1826
Close #1835
Big thanks for #2828