Avoid removing partial paths when uninstalling #3092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x3ro
force-pushed
the
bash-profile-truncation-fix
branch
from
c331adb
to
82101cd
Compare
x3ro
force-pushed
the
bash-profile-truncation-fix
branch
from
82101cd
to
5c4b4a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2967
do_remove_from_pathsso that it only removes full linesOne thing I'm not 100% sure about is whether it's okay to call
.lines()and then later re-build the file with.join("\n"). For example in the case of CRLF line breaks, this would certainly rewrite the file entirely. Is this a concern for the Unix implementation?I'm fairly sure this still needs some work, but the overall idea is correct, I believe. Feedback welcome :)