Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate using a community maintained progress bar #1835

Open
rbtcollins opened this issue May 5, 2019 · 3 comments
Open

Investigate using a community maintained progress bar #1835

rbtcollins opened this issue May 5, 2019 · 3 comments
Milestone

Comments

@rbtcollins
Copy link
Contributor

Describe the problem you are trying to solve
Stop us playing whack-a-mole with progress bars. Also get nicer, shinier ones. #1826 is perhaps a case of this (but perhaps also is just in the term detection bucket).

Describe the solution you'd like
Use https://github.com/mitsuhiko/indicatif

Notes
Some care is needed in investigating the behaviours involved but I think overall we could shrink rustup's code a bit, as well as directing effort on corner case configurations to a more central place, rather than the leaf node that rustup is.

@rbtcollins rbtcollins changed the title Use a community maintained progress bar Investigate using a community maintained progress bar May 5, 2019
@rbtcollins
Copy link
Contributor Author

@mitsuhiko

@mitsuhiko
Copy link

I would love to get people on board to improve indicatif :)

@kinnison
Copy link
Contributor

kinnison commented May 7, 2019

I think that switching to indicatif or another similar library would be an interesting approach. It'd be a significant departure for the current UI if we also funnelled all messaging through such a beast, so we'd need to think carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants