debuginfo: embed gdb visualizers in module #1462
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
reviewed
Mar 4, 2024
| @@ -35,6 +35,23 @@ impl DebugContext { | |||
| } | |||
| Ok(()) | |||
| }); | |||
|
|
|||
| self.add_gdb_debugger_visualizers(product); | |||
There was a problem hiding this comment.
This function needs to be called at
rustc_codegen_cranelift/src/main_shim.rs
Line 40 in 8c46d93
bjorn3
reviewed
Mar 4, 2024
| self.add_gdb_debugger_visualizers(product); | ||
| } | ||
|
|
||
| fn add_gdb_debugger_visualizers(&mut self, product: &mut ObjectProduct) { |
There was a problem hiding this comment.
If https://github.com/rust-lang/rust/blob/7606c13961ddc1174b70638e934df0439b7dc515/compiler/rustc_codegen_llvm/src/debuginfo/gdb.rs#L85-L117 returns false you need to skip adding the section.
bjorn3
reviewed
Mar 4, 2024
| } | ||
|
|
||
| fn add_gdb_debugger_visualizers(&mut self, product: &mut ObjectProduct) { | ||
| let mut section = WriterRelocate::new(self.endian); |
There was a problem hiding this comment.
No need to go through WriterRelocate here. A plain Vec is enough. There will be no relocations inside this section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1386