Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 4 pull requests #124945

Closed
wants to merge 10 commits into from
Closed

Rollup of 4 pull requests #124945

wants to merge 10 commits into from

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

nnethercote and others added 10 commits May 8, 2024 11:00
@nnethercote
Remove unused step_trait feature.
56dc98b 
Also sort the features.
@nnethercote
Remove unused LinkSelfContainedDefault::is_linker_enabled method.
69b86f6
@klensy
opt-dist: use xz2 instead of xz crate
39159a3 
xz crate consist of simple reexport of xz2 crate. Why? Idk.
@lcnr
analyse visitor: build proof tree in probe
83e6da0
@lcnr
update crashes
feff752
@lcnr
always use GenericArgsRef
8f90625
@matthiaskrgr
Rollup merge of rust-lang#124915 - nnethercote:rustc_target-cleanups,…
e6f4df8 
… r=bjorn3

`rustc_target` cleanups

Minor improvement I found while looking at this code.

r? `@lqd`
@matthiaskrgr
Rollup merge of rust-lang#124927 - klensy:xz3, r=Kobzol
3847582 
opt-dist: use xz2 instead of xz crate

xz crate consist of simple reexport of xz2 crate. Why? Idk.

Totally not a backdoor.
@matthiaskrgr
Rollup merge of rust-lang#124936 - lcnr:cool-beans, r=compiler-errors
b9c69f2 
analyse visitor: build proof tree in probe

see inline comments

fixes rust-lang#124791
fixes rust-lang#124702

r? `@compiler-errors`
@matthiaskrgr
Rollup merge of rust-lang#124943 - lcnr:generic-args-ref, r=compiler-…
2f7df58 
…errors

always use `GenericArgsRef`

r? `@compiler-errors`
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative rollup A PR which is a rollup labels May 9, 2024
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=4

@bors
Copy link
Contributor

bors commented May 9, 2024

📌 Commit 2f7df58 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2024
@bors
Copy link
Contributor

bors commented May 9, 2024

⌛ Testing commit 2f7df58 with merge a44a2b8...

bors added a commit to rust-lang-ci/rust that referenced this pull request May 9, 2024
@bors
Auto merge of rust-lang#124945 - matthiaskrgr:rollup-r6395sn, r=matth…
a44a2b8 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#124915 (`rustc_target` cleanups)
 - rust-lang#124927 (opt-dist: use xz2 instead of xz crate)
 - rust-lang#124936 (analyse visitor: build proof tree in probe)
 - rust-lang#124943 (always use `GenericArgsRef`)

r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
[RUSTC-TIMING] test test:true 13.637
[RUSTC-TIMING] alloctests test:true 60.171
[RUSTC-TIMING] allocbenches test:true 64.550
[RUSTC-TIMING] corebenches test:true 66.252
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.

@bors
Copy link
Contributor

bors commented May 10, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@matthiaskrgr @bors @rust-log-analyzer @rustbot @nnethercote @klensy @lcnr