Make #![feature] suggestion MaybeIncorrect
#124926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rustbot has assigned @petrochenkov. Use |
rustbot
added
S-waiting-on-review
|
Yeah IMO @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 9, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#124893 (Make a minimal amount of region APIs public) - rust-lang#124919 (Add `ErrorGuaranteed` to `Recovered::Yes` and use it more.) - rust-lang#124923 (interpret/miri: better errors on failing offset_from) - rust-lang#124924 (chore: remove repetitive words) - rust-lang#124926 (Make `#![feature]` suggestion MaybeIncorrect) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 9, 2024
Rollup merge of rust-lang#124926 - Alexendoo:feature-maybe-incorrect, r=est31 Make `#![feature]` suggestion MaybeIncorrect Fixes rust-lang/rust-clippy#12784 The `unstable_name_collisions` lint uses `disabled_nightly_features` to mention the feature name, but accepting the suggestion would result in an ambiguity error There are other calls where accepting the feature gate would fix code when ran with `cargo fix --broken-code`, though it's not always desirable to add a feature gate even if the user is currently on nightly so MaybeIncorrect seems appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rust-lang/rust-clippy#12784
The
unstable_name_collisionslint usesdisabled_nightly_featuresto mention the feature name, but accepting the suggestion would result in an ambiguity errorThere are other calls where accepting the feature gate would fix code when ran with
cargo fix --broken-code, though it's not always desirable to add a feature gate even if the user is currently on nightly so MaybeIncorrect seems appropriate