Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interpret/miri: better errors on failing offset_from #124923

Merged
merged 1 commit into from
May 9, 2024

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented May 9, 2024

@rustbot
Copy link
Collaborator

rustbot commented May 9, 2024

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 9, 2024
@rustbot
Copy link
Collaborator

rustbot commented May 9, 2024

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

@compiler-errors
Copy link
Member

r? compiler-errors @bors r+ rollup

@bors
Copy link
Contributor

bors commented May 9, 2024

📌 Commit 41d36a0 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request May 9, 2024
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#124893 (Make a minimal amount of region APIs public)
 - rust-lang#124919 (Add `ErrorGuaranteed` to `Recovered::Yes` and use it more.)
 - rust-lang#124923 (interpret/miri: better errors on failing offset_from)
 - rust-lang#124924 (chore: remove repetitive words)
 - rust-lang#124926 (Make `#![feature]` suggestion MaybeIncorrect)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 024881a into rust-lang:master May 9, 2024
6 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 9, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 9, 2024
Rollup merge of rust-lang#124923 - RalfJung:offset-from-errors, r=compiler-errors

interpret/miri: better errors on failing offset_from

Fixes rust-lang/miri#3104
@RalfJung RalfJung deleted the offset-from-errors branch May 10, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing Miri error when byte_offset_from is used on two different invalid pointers.
5 participants