reachable computation: extend explanation of what this does, and why #124904
+22
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
lqd
reviewed
May 8, 2024
saethlin
reviewed
May 9, 2024
Comment on lines
6
to
7
| //! item. This obviously includes all public items. However, some of these items cannot be compiled | ||
| //! to machine code (because they are generic), and for some the machine code is not sufficient |
There was a problem hiding this comment.
Suggested change
| //! item. This obviously includes all public items. However, some of these items cannot be compiled | |
| //! to machine code (because they are generic), and for some the machine code is not sufficient | |
| //! item. This obviously includes all public items. However, some of these items cannot be lowered | |
| //! (because they are generic), and for some the machine code is not sufficient |
🤷 I dislike mentioning "machine code" because a codegen backend can do things like emit JavaScript, but I don't have a particularly compelling alternative in mind.
There was a problem hiding this comment.
"lowered" is extremely vague, I don't think the term is precise enough for this discussion.
And we're still mentioning machine code later in the same sentence so I don't think anything is gained by this change.
I've pushed an alternative proposal.
There was a problem hiding this comment.
Makes sense, I like the alternative
|
I like everything else in here, except the one little thing I commented on. 👍 |
|
@bors r+ rollup=always |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 11, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#124233 (Add `-lmingwex` second time in `mingw_libs`) - rust-lang#124318 (ignore generics args in attribute paths) - rust-lang#124899 (bootstrap: add comments for the automatic dry run) - rust-lang#124904 (reachable computation: extend explanation of what this does, and why) - rust-lang#124930 (Make sure we consume a generic arg when checking mistyped turbofish) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 11, 2024
Rollup merge of rust-lang#124904 - RalfJung:reachable, r=tmiasko reachable computation: extend explanation of what this does, and why Follow-up to rust-lang#122769. I had the time to think about this some more, in particular in the context of rust-lang#119214, so I felt it was worth extending these comments some more. I also gave up on the context of "externally reachable" as it is not called that way anywhere else in the compiler. Cc `@tmiasko` `@saethlin`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #122769. I had the time to think about this some more, in particular in the context of #119214, so I felt it was worth extending these comments some more.
I also gave up on the context of "externally reachable" as it is not called that way anywhere else in the compiler.
Cc @tmiasko @saethlin