Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap: add comments for the automatic dry run #124899

Merged
merged 2 commits into from
May 11, 2024
Merged

bootstrap: add comments for the automatic dry run #124899

merged 2 commits into from
May 11, 2024

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented May 8, 2024

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented May 8, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 8, 2024
jyn514
jyn514 approved these changes May 9, 2024
View reviewed changes
src/bootstrap/src/lib.rs Outdated Show resolved Hide resolved
@RalfJung @jyn514
fix typo
87c09fe 
Co-authored-by: jyn <github@jyn.dev>
@onur-ozkan
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 10, 2024

📌 Commit 87c09fe has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2024
@jieyouxu jieyouxu mentioned this pull request May 11, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2024
@bors
Auto merge of rust-lang#124993 - jieyouxu:rollup-u02aso7, r=jieyouxu
f9a3fd9 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#124233 (Add `-lmingwex` second time in `mingw_libs`)
 - rust-lang#124318 (ignore generics args in attribute paths)
 - rust-lang#124899 (bootstrap: add comments for the automatic dry run)
 - rust-lang#124904 (reachable computation: extend explanation of what this does, and why)
 - rust-lang#124930 (Make sure we consume a generic arg when checking mistyped turbofish)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 881fa5b into rust-lang:master May 11, 2024
6 checks passed
@rustbot rustbot added this to the 1.80.0 milestone May 11, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2024
@rust-timer
Unrolled build for rust-lang#124899
745e932 
Rollup merge of rust-lang#124899 - RalfJung:bootstrap-dry, r=onur-ozkan

bootstrap: add comments for the automatic dry run
@RalfJung RalfJung deleted the bootstrap-dry branch May 11, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@RalfJung @rustbot @onur-ozkan @bors @jyn514 @Mark-Simulacrum