Disallow hidden references to mutable static #124895
Open
+454
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Sorry, I can only review interpreter and Miri PRs. r? compiler |
|
r? @davidtwco |
This comment has been minimized.
This comment has been minimized.
obeis
force-pushed
the
static-mut-hidden-ref
branch
from
ef8ab6d
to
ac71600
Compare
rustbot
added
A-testsuite
This comment has been minimized.
This comment has been minimized.
obeis
force-pushed
the
static-mut-hidden-ref
branch
from
ac71600
to
968dfbc
Compare
This comment has been minimized.
This comment has been minimized.
davidtwco
added
S-waiting-on-author
|
Marking as waiting on author since you've made this a draft. |
obeis
force-pushed
the
static-mut-hidden-ref
branch
from
968dfbc
to
7d2fd98
Compare
This comment has been minimized.
This comment has been minimized.
obeis
force-pushed
the
static-mut-hidden-ref
branch
from
7d2fd98
to
72b1c9b
Compare
This comment has been minimized.
This comment has been minimized.
obeis
force-pushed
the
static-mut-hidden-ref
branch
from
72b1c9b
to
6467ccd
Compare
This comment has been minimized.
This comment has been minimized.
obeis
force-pushed
the
static-mut-hidden-ref
branch
from
6467ccd
to
abfd0a0
Compare
|
The Miri subtree was changed cc @rust-lang/miri Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
|
@rustbot ready |
rustbot
added
S-waiting-on-review
RalfJung
reviewed
May 11, 2024
src/tools/miri/tests/pass-dep/concurrency/tls_pthread_drop_order.rs
Outdated
Show resolved
Hide resolved
obeis
force-pushed
the
static-mut-hidden-ref
branch
from
abfd0a0
to
5a544f1
Compare
|
@obeis Are you planning on taking care of these FIXMEs? I can't tell what the plan is here. I don't see one written anywhere. If you're not going to handle them in this PR or in another PR shortly after this is merged, do you mind someone else handling them? |
|
@saethlin I plan to address them in another PR. Could you please open an issue for that, and assign it to me? |
|
I honestly don't know how GitHub assignment stuff works. You aren't in the dropdown or search. You can comment |
|
(You can |
This was referenced May 14, 2024
flip1995
reviewed
May 15, 2024
src/tools/clippy/tests/ui/checked_unwrap/simple_conditionals.rs
Outdated
Show resolved
Hide resolved
obeis
force-pushed
the
static-mut-hidden-ref
branch
from
5a544f1
to
8037ac7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #123060
Tracking: