Migrate run-make/rustdoc-output-path to rmake
#124888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
|
Some changes occurred in run-make tests. cc @jieyouxu |
jieyouxu
reviewed
May 8, 2024
| use run_make_support::{rustdoc, tmp_dir}; | ||
|
|
||
| fn main() { | ||
| rustdoc().input("foo.rs").output(tmp_dir().join("foo/bar/doc")).run(); |
There was a problem hiding this comment.
I know this is a direct translation of the original test, but the original test doesn't actually check if the path exists -- it only checked that rustdoc with non-existent output folder returns a success status code.
There was a problem hiding this comment.
Should I add this check then? Doesn't hurt to check that too I suppose.
There was a problem hiding this comment.
I think we should probably check that the directory is created yeah
GuillaumeGomez
force-pushed
the
migrate-rustdoc-output-path
branch
from
651906d
to
2b0a4ea
Compare
|
Feel free to r=me after CI is green |
|
@bors r=jieyouxu rollup |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #124916) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
GuillaumeGomez
force-pushed
the
migrate-rustdoc-output-path
branch
from
2b0a4ea
to
24d96fa
Compare
|
Rebased. @bors r=jieyouxu rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 10, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#124615 (coverage: Further simplify extraction of mapping info from MIR) - rust-lang#124778 (Fix parse error message for meta items) - rust-lang#124807 (Migrate `run-make/rustdoc-io-error` to `rmake.rs`) - rust-lang#124957 (Make `Ty::builtin_deref` just return a `Ty`) Failed merges: - rust-lang#124888 (Migrate `run-make/rustdoc-output-path` to rmake) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 10, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#124615 (coverage: Further simplify extraction of mapping info from MIR) - rust-lang#124778 (Fix parse error message for meta items) - rust-lang#124797 (Refactor float `Primitive`s to a separate `Float` type) - rust-lang#124888 (Migrate `run-make/rustdoc-output-path` to rmake) - rust-lang#124957 (Make `Ty::builtin_deref` just return a `Ty`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 10, 2024
Rollup merge of rust-lang#124888 - GuillaumeGomez:migrate-rustdoc-output-path, r=jieyouxu Migrate `run-make/rustdoc-output-path` to rmake Part of rust-lang#121876. r? ``@jieyouxu``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #121876.
r? @jieyouxu