add pull request template asking for relevant tracking issues #123492
Conversation
rustbot
added
the
S-waiting-on-review
.github/pull_request_template.md
Outdated
| @@ -0,0 +1,10 @@ | |||
| related tracking issue: | |||
There was a problem hiding this comment.
I'm tempted to say that we should do without this line and just include the comment that might be sufficient to remind people?
| related tracking issue: |
.github/pull_request_template.md
Outdated
|
|
||
| This automatically references this PR in the tracking issue which makes it far easier | ||
| to see the ongoing process on a given issue and also provides a list of the relevant | ||
| work when summarizing a feature for stabilization. |
There was a problem hiding this comment.
We could also remind people that they can use r? here to select a reviewer if there is someone who has been mentoring them or seems appropriate for the work?
There was a problem hiding this comment.
I did that, using r<zero-width space>? <reviewer name> in the html comment as otherwise bors ends up confused if people don't remove it
|
Would appreciate opinions on whether this is desirable, cc @rust-lang/compiler @rust-lang/libs |
|
Seems like a good idea to me |
Libs also keeps an implementation history list in tracking issues so this SGTM. |
|
given the feedback I am going to merge this. we can always revert this if it causes any issues or is annoying. Will open a thread on zulip in a few weeks to get feedback if nothing blew up since then. @bors r=davidtwco rollup=always |
bors
added
S-waiting-on-bors
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#123122 (Fix incorrect suggestion for undeclared hrtb lifetimes in where clauses.) - rust-lang#123492 (add pull request template asking for relevant tracking issues) - rust-lang#125276 (Fix parsing of erroneously placed semicolons) - rust-lang#125310 (Move ~100 tests from tests/ui to subdirs) - rust-lang#125357 (Migrate `run-make/rustdoc-scrape-examples-multiple` to `rmake.rs`) - rust-lang#125369 (Don't do cc detection for synthetic targets) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#123492 - lcnr:master, r=davidtwco add pull request template asking for relevant tracking issues As mentioned at RustNation, I would like to remind PR authors to link to relevant tracking issues when opening PRs as it is otherwise very easy to forget doing so. There's a certain amount of conflict between making the template as small as possible while still being clear for new contributors. I am very much open to changes here but really want to try this out. Also unsure how much formal buy-in we need here. Maybe merge this pinging t-compiler and t-libs, and then ask how people feel about this on zulip in a few weeks? r? `@davidtwco`
As mentioned at RustNation, I would like to remind PR authors to link to relevant tracking issues when opening PRs as it is otherwise very easy to forget doing so.
There's a certain amount of conflict between making the template as small as possible while still being clear for new contributors. I am very much open to changes here but really want to try this out.
Also unsure how much formal buy-in we need here. Maybe merge this pinging t-compiler and t-libs, and then ask how people feel about this on zulip in a few weeks?
r? @davidtwco