-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix c_char on AIX #122986
Fix c_char on AIX #122986
Conversation
cc @ecnelises and @bzEq as target maintainers |
Re-rolling to hopefully get someone with target experience: |
@rustbot author (while libc is merged) Per rust-lang/libc#3631 (comment), it looks like target maintainers are happy with this change, and our policy is that no further review for tier-3 targets is required. |
You still need to remove the Github draft status 🙂 |
Thanks for taking care of this! I did not notice libc has been bumped. |
It might be obvious, but I would like to note that there is an inconsistency, resulting in syntax errors on AIX while the libc side (#124560) has already been merged, but this PR is still open. cargo init
cargo add rustix
cargo check (tested with rustix-0.38.34 on AIX)
|
@bors r+ rollup |
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#121377 (Stabilize `LazyCell` and `LazyLock`) - rust-lang#122986 (Fix c_char on AIX) - rust-lang#123803 (Fix `VecDeque::shrink_to` UB when `handle_alloc_error` unwinds.) - rust-lang#124080 (Some unstable changes to where opaque types get defined) - rust-lang#124667 (Stabilize `div_duration`) - rust-lang#125472 (tidy: validate LLVM component names in tests) - rust-lang#125523 (Exit the process a short time after entering our ctrl-c handler) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#122986 - taiki-e:aix-c-char, r=Mark-Simulacrum Fix c_char on AIX Closes rust-lang#122985
Closes #122985