fix: use hir_with_context to produce correct snippets for assigning_clones

[shanretoo]

The assigning_clones lint is producing wrong output when the assignment is a macro call.
Since Applicability level Unspecified will never be changed inside hir_with_applicability, so it is safe here to replace hir_with_applicability with hir_with_context to generate snippets of the macro call instead of the expansion.

fixes #12776

changelog: [assigning_clones]: use hir_with_context to produce correct snippets

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @blyxyas (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[de-vri-es]

Maybe you linked the wrong issue? #12778 will not be fixed by this. In #12778 I argue that assigning_clones should be allow by default, even if it has no false positives or wrong suggestions.

I think maybe you meant to link this issue: #12776 ?

[shanretoo]

Maybe you linked the wrong issue? #12778 will not be fixed by this. In #12778 I argue that assigning_clones should be allow by default, even if it has no false positives or wrong suggestions.

I think maybe you meant to link this issue: #12776 ?

Sorry, updated the issue link.

[blyxyas]

LGTM, thanks! ❤️

[blyxyas]

@bors r+

[bors]

📌 Commit 99a42ba has been approved by blyxyas

It is now in the queue for this repository.

[bors]

⌛ Testing commit 99a42ba with merge baf2a23...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas
Pushing baf2a23 to master...