Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore _to_string lints in code from_expansion #12780

Merged
merged 1 commit into from
May 9, 2024

Conversation

future-highway
Copy link
Contributor

Includes the string_to_string and str_to_string lints.

changelog: [str_to_string]: Ignore code from expansion
changelog: [string_to_string]: Ignore code from expansion

Includes the `string_to_string` and `str_to_string` lints.
@rustbot
Copy link
Collaborator

rustbot commented May 8, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 8, 2024
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented May 9, 2024

📌 Commit cd00f5b has been approved by Manishearth

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented May 9, 2024

⌛ Testing commit cd00f5b with merge 68dbc84...

@bors
Copy link
Collaborator

bors commented May 9, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 68dbc84 to master...

@bors bors merged commit 68dbc84 into rust-lang:master May 9, 2024
5 checks passed
@future-highway future-highway deleted the str-to-string-expansions branch May 9, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants