Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

now that {f16,f128}::DIGITS are available, use them #12769

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

now that {f16,f128}::DIGITS are available, use them #12769

wants to merge 2 commits into from
+4 −3

Conversation

tspiteri
Copy link
Contributor

@tspiteri tspiteri commented May 6, 2024

Now that rust-lang/rust#123850 has added {f16,f128}::DIGITS, use them and fix a FIXME.

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented May 6, 2024

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 6, 2024
@tspiteri
Copy link
Contributor Author

tspiteri commented May 7, 2024

Test failed because this needs rustc 1.80.0-nightly (7d83a4c13 2024-05-06).

@J-ZhengLi
Copy link
Member

Test failed because this needs rustc 1.80.0-nightly (7d83a4c13 2024-05-06).

Now that the toolchain version is updated, would you mind try again with a quick rebase? @tspiteri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@llogiq llogiq

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tspiteri @rustbot @J-ZhengLi @llogiq