make sure the msrv for const_raw_ptr_deref is met when linting [missing_const_for_fn]
#12713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
J-ZhengLi
changed the title
const_ptr_deref is met when linting [missing_const_for_fn]const_raw_ptr_deref is met when linting [missing_const_for_fn]
y21
reviewed
Apr 25, 2024
dswij
added
S-waiting-on-author
J-ZhengLi
force-pushed
the
issue8864
branch
3 times, most recently
from
f6b2d85
to
e062224
Compare
|
Finally got some time to work on this. @rustbot ready |
rustbot
added
S-waiting-on-review
y21
reviewed
May 14, 2024
|
Since dswij seems to be a little busy and has a bunch of other PRs assigned and I already started reviewing this, I'm gonna steal this one to move it forwards. Hope you dont mind :D |
|
Yeah, feel free :) |
|
Thanks! @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
1 similar comment
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
|
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #8864
changelog: make sure the msrv for
const_ptr_derefis met when linting [missing_const_for_fn]