make [manual_map] ignore types that contain dyn
#12712
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Alexendoo
reviewed
Apr 25, 2024
Comment on lines
+76
to
+89
| fn foo<T: DummyTrait, F: Fn() -> Result<T, ()>>(f: F) { | ||
| // Don't lint | ||
| let _: Option<Result<Box<dyn DummyTrait>, ()>> = match Some(0) { | ||
| Some(_) => Some(match f() { | ||
| Ok(res) => Ok(Box::new(res)), | ||
| _ => Err(()), | ||
| }), | ||
| None => None, | ||
| }; |
There was a problem hiding this comment.
The problem is that it doesn't catch the adjustment rather than the presence of a dyn, e.g. the same can occur with an unsized coercion
fn main() {
let x: &[u8; 4] = b"1234";
// ok
let _: Option<Box<&[u8]>> = match Some(()) {
Some(_) => Some(Box::new(x)),
None => None,
};
// error[E0308]: mismatched types
let _: Option<Box<&[u8]>> = Some(()).map(|_| Box::new(x));
}There was a problem hiding this comment.
Oops, you're right, I'll see what I can do with it
dswij
added
S-waiting-on-author
J-ZhengLi
force-pushed
the
issue12666
branch
2 times, most recently
from
d44c289
to
f01faac
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #12659
[
manual_map] and [manual_filter] shares the same check logic, but this issue doesn't seems like it could affectmanual_filter(?)changelog: make [
manual_map] ignore types that containdyn