Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation of needless_range_loop #12701

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tatounee
Copy link

fixes #6930 6930

Add a note telling the user that the suggestions might remove (maybe expected) iterations in for loop.

changelog: [needless_range_loop]: Improve documentation

@rustbot
Copy link
Collaborator

rustbot commented Apr 21, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @dswij (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 21, 2024
@blyxyas
Copy link
Member

blyxyas commented Apr 21, 2024

r? blyxyas

@rustbot rustbot assigned blyxyas and unassigned dswij Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

needless_range_loop produces code with different behaviour
4 participants