Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rust-analyzer manual to mdbook #10791

Closed
wants to merge 43 commits into from
Closed

Move rust-analyzer manual to mdbook #10791

wants to merge 43 commits into from

Conversation

joshrotenberg
Copy link

@joshrotenberg joshrotenberg commented Nov 18, 2021

This refreshes the asciidoc manual to use mdbook.

See responses/ideas in #9504.

Currently a work in progress. If this seems like the right direction, I'll continue with the list below.

TODO:

  • For now, verbatim copy content from current manual to corresponding markdown file in manual.
  • Figure out how to deal with generated content.
    • generated_diagnostics - crates/ide-diagnostics/src/tests/sourcegen.rs
    • generated_features - crates/rust-analyzer/tests/slow-tests/sourcegen.rs
    • generated_config - crates/rust-analyzer/src/config.rs
    • generated_assists - crates/ide-assists/src/tests/sourcegen.rs
  • Move landing page to introduction.
  • Add Quickstart.
  • Copy over docs/dev md files to manual/src/contributing.
  • Figure out changes needed for deployment.
  • Add docs on how to build/test/run/modify book.

Fixes #9504.

@joshrotenberg
Copy link
Author

joshrotenberg commented Nov 18, 2021

Screen Shot 2021-11-18 at 5 12 58 PM

@joshrotenberg joshrotenberg changed the title Rework manual Move rust-analyzer manual to mdbook Nov 19, 2021
@joshrotenberg joshrotenberg marked this pull request as ready for review December 17, 2021 22:45
@Veykril
Copy link
Member

Veykril commented Jul 18, 2022

I apologize that no one has gotten back to the PR after 7 months, looks like it feel off of everyone's radar. With that said, are you still interested in this PR? Then I'd take a look at what you've got here and commit some time to review/discussion.

@joshrotenberg
Copy link
Author

I apologize that no one has gotten back to the PR after 7 months, looks like it feel off of everyone's radar. With that said, are you still interested in this PR? Then I'd take a look at what you've got here and commit some time to review/discussion.

No need to apologize, I understand. I’m definitely still interested. I can take another look at it and remember how I left it this week.

@joshrotenberg
Copy link
Author

Ok, getting back to this. If you like this approach, I can go through and move the current static content from the docs into the new mdbook/markdown format, and then we can discuss how to manage the generated content, as well as any changes/updates you'd like to make to the contents. I may make some editorial updates while I move things over where appropriate. Why don't I do a couple of sections and then we can review and see if you're happy with how it's turning out, and go from there.

@Veykril
Copy link
Member

Veykril commented Jul 26, 2022

Ye I think this looks good, as the issue outlines we should think a bit about the landing page/front page later on but I don't think that impacts the books structure so that's something for later.

Sounds like a plan 👍

@joshrotenberg
Copy link
Author

joshrotenberg commented Aug 5, 2022

Ok, I think this PR is at the point where the remaining changes start touching a lot more files (mostly the generated stuff, of course), so the question is this: would it be preferable to have this overall documentation change (moving to mdbook, I mean) be a process over several PRs (say, this one for just new content and another for the cutover) or just one PR that has all the changes?

Edit to add that while I don't see the changes required for the generated content to be significant in effect (mostly just ascii doc to markdown stuff), there will be a lot of them given that content is pulled from comments.

@joshrotenberg
Copy link
Author

Screen Shot 2022-08-05 at 8 55 50 PM

Quick peek at how the features page looks. I'll try to get the latest deployed to gh pages on my fork to make it easier to see the current state.

@joshrotenberg
Copy link
Author

OK! The last big round of updates takes the Features page out of ascii doc and into markdown. This involved touching quite a few files, almost all of which was moving from adoc to md in the comments that are parsed. Fortunately, there is a fair amount of crossover. There were also the small code changes required to write the markdown file.

I had originally stubbed out a single page per feature. The benefit of this is that we get the full list in the navigation markdown. Since the current process generates to a single file, though, it made more sense to stick with that for now I think, so I added a TOC to the top of the Features page. It's ... ok. I think it's a detail that can potentially get fixed later on.

In regards to my previous comment, making it so that the old and new manual can coexist seems like more work than necessary, so I'm going to plan on making this PR a clean cutover unless someone disagrees. I'll go through and get the other generated sections moved over as well.

@bors
Copy link
Collaborator

bors commented Sep 19, 2022

☔ The latest upstream changes (presumably #13262) made this pull request unmergeable. Please resolve the merge conflicts.

@Veykril
Copy link
Member

Veykril commented Sep 19, 2022

Ah I never asked, should I take a look by now or are you still moving some things around?

@joshrotenberg
Copy link
Author

Ah I never asked, should I take a look by now or are you still moving some things around?

Still some stuff to work on, had to take a break for other things, but I should be able to get back to it soon.

@Veykril
Copy link
Member

Veykril commented Sep 20, 2022

No rush

@joshrotenberg joshrotenberg mentioned this pull request Sep 30, 2022
14 tasks
@joshrotenberg
Copy link
Author

Had some environment issues, decided to start fresh with a better conversion process. See #13316

@joshrotenberg joshrotenberg mentioned this pull request Oct 1, 2022
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manual needs to be more helpful, friendly, and better organized
3 participants