Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite parser as part of new regex-syntax crate. #87

Merged
merged 4 commits into from May 27, 2015
Merged

Commits on May 25, 2015

  1. Rewrite parser as part of new regex-syntax crate.

    This commit introduces a new `regex-syntax` crate that provides a
    regular expression parser and an abstract syntax for regular
    expressions. As part of this effort, the parser has been rewritten and
    has grown a substantial number of tests.
    
    The `regex` crate itself hasn't changed too much. I opted for the
    smallest possible delta to get it working with the new regex AST.
    In most cases, this simplified code because it no longer has to deal
    with unwieldy flags. (Instead, flag information is baked into the AST.)
    
    Here is a list of public facing non-breaking changes:
    
    * A new `regex-syntax` crate with a parser, regex AST and lots of tests.
      This closes #29 and fixes #84.
    * A new flag, `x`, has been added. This allows one to write regexes with
      insignificant whitespace and comments.
    * Repetition operators can now be directly applied to zero-width
      matches. e.g., `\b+` was previously not allowed but now works.
      Note that one could always write `(\b)+` previously. This change
      is mostly about lifting an arbitrary restriction.
    
    And a list of breaking changes:
    
    * A new `Regex::with_size_limit` constructor function, that allows one
      to tweak the limit on the size of a compiled regex. This fixes #67.
      The new method isn't a breaking change, but regexes that exceed the
      size limit (set to 10MB by default) will no longer compile. To fix,
      simply call `Regex::with_size_limit` with a bigger limit.
    * Capture group names cannot start with a number. This is a breaking
      change because regexes that previously compiled (e.g., `(?P<1a>.)`)
      will now return an error. This fixes #69.
    * The `regex::Error` type has been changed to reflect the better error
      reporting in the `regex-syntax` crate, and a new error for limiting
      regexes to a certain size. This is a breaking change. Most folks just
      call `unwrap()` on `Regex::new`, so I expect this to have minimal
      impact.
    
    Closes #29, #67, #69, #79, #84.
    
    [breaking-change]
    BurntSushi committed May 25, 2015
    Configuration menu
    Copy the full SHA
    a66df89 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    69e242d View commit details
    Browse the repository at this point in the history

Commits on May 27, 2015

  1. Fixes from code review.

    The big change here is the addition of a non-public variant in the
    error enums. This will hint to users that one shouldn't exhaustively
    match the enums in case new variants are added.
    BurntSushi committed May 27, 2015
    Configuration menu
    Copy the full SHA
    6d5e909 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    068514f View commit details
    Browse the repository at this point in the history