Move regex-capi to 2021 & inline format-args #1109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the code a bit easier to read and smaller. Some of it was done with this command, and later fixed by hand: ``` cargo clippy --workspace --allow-dirty --fix --benches --tests --bins -- -A clippy::all -W clippy::uninlined_format_args ```
nyurik
changed the title
BurntSushi
requested changes
Oct 16, 2023
| @@ -11,7 +11,7 @@ description = """ | |||
| A C API for Rust's regular expression library. | |||
| """ | |||
| workspace = ".." | |||
| edition = "2018" | |||
| edition = "2021" | |||
There was a problem hiding this comment.
Probably set rust-version = "1.65" for consistency with other crates?
regex-capi/src/macros.rs
Outdated
| &mut io::stderr(), | ||
| "panic unwind caught, aborting: {:?}", | ||
| msg); | ||
| let _ = writeln!(&mut io::stderr(), "panic unwind caught, aborting: {msg:?}"); |
There was a problem hiding this comment.
I follow a 79 column (inclusive) rule. I'm kind of surprised rustfmt doesn't take care of this here... Oh, because it's in a macro. So it will need to be wrapped manually.
|
fixed |
|
@BurntSushi hi, friendly ping - let me know if anything else is needed for this and other regex PRs. Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the code a bit easier to read and smaller.
The capi crate was updated to the 2021 edition to avoid accidental
panic!and other edge cases with inlined formats.Some of it was done with this command, and later fixed by hand: