New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump ui_test to 0.22 #3279
base: master
Are you sure you want to change the base?
bump ui_test to 0.22 #3279
Conversation
// keep in sync with `./miri run` | ||
config.comment_defaults.base().edition = Some(Spanned::dummy("2021".into())).into(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit unclear what should be kept in sync.
// keep in sync with `./miri run` | |
config.comment_defaults.base().edition = Some(Spanned::dummy("2021".into())).into(); | |
let edition = "2021"; // keep in sync with `./miri run` | |
config.comment_defaults.base().edition = Some(Spanned::dummy(edition.into())).into(); |
But also... this is quite confusing, why do we need to Spanned
everything?
@@ -66,8 +67,6 @@ fn test_config(target: &str, path: &str, mode: Mode, with_dependencies: bool) -> | |||
} | |||
} | |||
program.args.push("-Zui-testing".into()); | |||
program.args.push("--target".into()); | |||
program.args.push(target.into()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the CI errors, removing --target
doesn't seem to be right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea ^^ looks like it
@rustbot author |
111ec7c
to
fef6736
Compare
☔ The latest upstream changes (presumably #3314) made this pull request unmergeable. Please resolve the merge conflicts. |
No description provided.