Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable clippy support for format-like macros #665

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

nyurik
Copy link
Contributor

@nyurik nyurik commented Feb 6, 2025

Add #[clippy::format_args] as described in Clippy book

This is a new feature in v1.85

@Thomasdezeeuw
Copy link
Collaborator

How does this work with older Clippy versions? Is this just ignored?

@nyurik
Copy link
Contributor Author

nyurik commented Feb 21, 2025

  • Older Clippy would work fine on anything that uses log as a dependency.
  • Older Clippy would only fail if you try to run it on the log crate itself - because it won't recognize the lint even though it thinks it "should". This is usually OK because unlike using it as a dependency, the lib itself should only be checked by one (stable) version of Clippy as part of CI

Copy link
Contributor

@KodrAus KodrAus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nyurik. This looks like it should be compatible with the log! macro syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants