Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some API of the key-value feature #585

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Remove some API of the key-value feature #585

merged 3 commits into from
Oct 9, 2023

Commits on Aug 29, 2023

  1. Remove AsMap and AsList type 

    These types are more related to serde and sval than they are to log.
Because of that is falls out of scope for the log crate.
    @Thomasdezeeuw
    Thomasdezeeuw committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    0f2e26d View commit details
    Browse the repository at this point in the history

  2. Remove ToValue for dyn fmt::{Debug,Display} and std::error::Error 

    To support downcasting the Value::capture_* methods should be used.
However with these ToValue implementations it's very easy to call
to_value and call it a day, too easy as you lose the downcasting ability
when you do. To prevent this gotcha remove these implenentations.
    @Thomasdezeeuw
    Thomasdezeeuw committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    0c80af3 View commit details
    Browse the repository at this point in the history

  3. Remove Key::to_borrowed_str 

    Key::as_str can be used instead.
    @Thomasdezeeuw
    Thomasdezeeuw committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    e6b6bde View commit details
    Browse the repository at this point in the history