-
Notifications
You must be signed in to change notification settings - Fork 1.1k
ci: Fixes for sparc and s390x #4317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Pedro Tammela <pctammela@gmail.com>
Signed-off-by: Pedro Tammela <pctammela@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thank you!
Do you know why the "`GLIBC_2.39' not found (required by /prog)" was showing up before for similar changes but no longer is?
This seems to have doubled s390x CI time from ~5 minutes to ~10 minutes. Not too much of a concern since it doesn't increase our total CI time by much, but I'm not sure why this would have changed. |
Signed-off-by: Pedro Tammela <pctammela@gmail.com> (backport <rust-lang#4317>) (cherry picked from commit 4776e0f)
Signed-off-by: Pedro Tammela <pctammela@gmail.com> (backport <rust-lang#4317>) (cherry picked from commit 1ae6552)
So it turns out s390x was not running at all, it was failing 5 times with the libc error then silently succeeding |
Oh wtf, great catch. We can probably clean up Lines 96 to 124 in 1c65dda
|
Description
Fixes the 'cannot find libc' error plaguing s390x and sparc. A side effect is that now these CIs will be tested on much more recent kernel headers (6.11).
Sources
Checklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see #3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI