macOs various updates. #3578
Open
macOs various updates. #3578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
devnexen
commented
Feb 10, 2024
devnexen
commented
- CI only for macOs arm64.
- Fixing build issues for macOs arm64.
- Adding macos cpu to arch api.
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use r? to explicitly pick a reviewer |
devnexen
force-pushed
the
macos_arm64_upd
branch
from
cba5173
to
e721608
Compare
JohnTitor
reviewed
Feb 17, 2024
Cargo.toml
Outdated
Comment on lines
109
to
110
| "x86_64-apple-darwin", | ||
| "x86_64-apple-ios", |
There was a problem hiding this comment.
This is for docs.rs and you don't have to touch.
src/unix/bsd/apple/mod.rs
Outdated
Comment on lines
6115
to
6116
| // FIXME: 2024 edition forbids static mut, no easy fix for both nightly/stable neither | ||
| //pub static mut mach_task_self_: ::mach_port_t; |
There was a problem hiding this comment.
We could just remove mach related items.
devnexen
force-pushed
the
macos_arm64_upd
branch
from
e721608
to
51100ae
Compare
JohnTitor
reviewed
Feb 18, 2024
src/unix/bsd/apple/mod.rs
Outdated
Comment on lines
6230
to
6238
| pub fn macho_cpu_type_for_arch_name( | ||
| archName: *const ::c_char, | ||
| tpe: *mut ::cpu_type_t, | ||
| subtpe: *mut ::cpu_subtype_t, | ||
| ) -> bool; | ||
| pub fn macho_arch_name_for_cpu_type( | ||
| tpe: ::cpu_type_t, | ||
| subtpe: ::cpu_subtype_t, | ||
| ) -> *const ::c_char; |
There was a problem hiding this comment.
These should exist on the mach crate.
devnexen
force-pushed
the
macos_arm64_upd
branch
from
51100ae
to
b101560
Compare
|
This looks great! Could we get it merged? |
JohnTitor
reviewed
Feb 25, 2024
libc-test/build.rs
Outdated
| @@ -203,6 +203,7 @@ fn test_apple(target: &str) { | |||
| "limits.h", | |||
| "locale.h", | |||
| "malloc/malloc.h", | |||
| "mach-o/utils.h", | |||
There was a problem hiding this comment.
I think this is now unneeded, right?
devnexen
force-pushed
the
macos_arm64_upd
branch
from
b101560
to
36c8345
Compare
JohnTitor
approved these changes
Feb 28, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
That's an unexpected error from the merge queue. |
- CI only for macOs arm64. - Fixing build issues for macOs arm64. - Adding macos cpu to arch api.
devnexen
force-pushed
the
macos_arm64_upd
branch
from
f144cb7
to
9058e77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.