Add fcntl OFD commands for macOS #3563
Conversation
|
r? @JohnTitor (rustbot has picked a reviewer for you, use r? to override) |
|
So I noticed that the tests run on macos-13, and macos-14 is available (possibly needed for the OFD feature, despite the constants being 4 years old according to the kernel changelog), and also that the tests only run on Intel chips. I do not think it would be too much work to add aarch64 to the macos testing (assuming GitHub has a runner for this). |
|
Could you rebase onto the latest main and squash commits into one? |
|
Yes, I'll do that soon, thanks. |
anacrolix
force-pushed
the
macos-ofd-fcntl
branch
from
e8a3800
to
b1acf8d
Compare
|
Okay, I've done that. It's extraordinarily painful, any reason you can't squash on merge? |
|
I don't think my change caused the macOS CI failure, I'm not sure what to do about that one. |
You updated the macOS version and it introduced some breaking changes, you have to account for that.
We use the merge queue and it doesn't allow me to select the merge method sadly. |
|
It'll take someone more knowledgable about macos to fix this I think. I didn't find anything straightforward to resolve it. |
|
I found #3575 but it's mysteriously closed. |
- CI only for macOs arm64. - Fixing build issues for macOs arm64. - Adding macos cpu to arch api.
Obey shellcheck ci/style.sh should be executable Define PRIVATE on apple to expose OFD commands Require macos-14
anacrolix
force-pushed
the
macos-ofd-fcntl
branch
from
b1acf8d
to
10ace1e
Compare
I also followed all the PR instructions and sorted the semver for apple.