Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional Linux AF_PACKET options (libc 0.2) #3540

Open
wants to merge 1 commit into
base: libc-0.2
Choose a base branch
from

Conversation

nathaniel-bennett
Copy link
Contributor

Added socket options, structs and other miscellaneous constants that make memory-mapped packet sockets possible in Linux--PACKET_TX_RING, PACKET_RX_RING, etc.

(adding this to libc 0.2 as 0.3 is in early development)

@rustbot
Copy link
Collaborator

rustbot commented Jan 12, 2024

r? @JohnTitor

(rustbot has picked a reviewer for you, use r? to override)

@JohnTitor
Copy link
Member

Sorry but could you add cfgs here? 0.2's MSRV is 1.13 and we need to add them, see https://github.com/rust-lang/libc/tree/libc-0.2#rust-version-support.

@nathaniel-bennett
Copy link
Contributor Author

Added cfgs for union types in latest force-push

@JohnTitor
Copy link
Member

JohnTitor commented Jan 19, 2024

CI fails, seems you also need libc_align cfg.
@rustbot author

@nathaniel-bennett
Copy link
Contributor Author

Added libc_align cfg to any structs that use repr(align)

@nathaniel-bennett
Copy link
Contributor Author

Resolved other issues with libc_const_size_of--ready to merge

}
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this diff is unintended.

@nathaniel-bennett
Copy link
Contributor Author

Removed the unintentional semicolon and rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants