Add FIXME for tempdir #126
Merged
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuki Okushi <jtitor@2k36.org>
|
tempdir also pulls in the remove_dir_all crate, that has a security vulnerability: https://rustsec.org/advisories/RUSTSEC-2023-0018.html Since this is a test-only vulnerability I guess it's not very critical, but should maybe be mentioned? |
|
I don't think it's worth doing so as it isn't vulnerable to us in general. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've received some PRs to replace the
tempdircrate withtempfileas the former is unmaintained.However, we cannot simply replace it due to our MSRV. Precisely speaking, it doesn't break but it needs some CI tweaks and we concluded that it wasn't worth doing so. This FIXME clarifies it.
Signed-off-by: Yuki Okushi jtitor@2k36.org