Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase minimum compiler version to 1.67 #452

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

jongiddy
Copy link
Contributor

No description provided.

Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! This seems to fix one out of two CI failures.

The one that's left says:

Run cargo build
    Updating crates.io index
error: failed to select a version for the requirement `cc = "^1.1"`
candidate versions found which didn't match: 1.0.99, 1.0.98, 1.0.97, ...
location searched: crates.io index
required by package `cloudflare-zlib-sys v0.3.5`
    ... which satisfies dependency `cloudflare-zlib-sys = "^0.3.5"` of package `flate2 v1.0.35 (/home/runner/work/flate2-rs/flate2-rs)`
Error: Process completed with exit code 101.

Could it be that dependency resolution takes the minimum Rustc version in account and can't select the version iof cc that it would need?

@Byron Byron added the question label Feb 11, 2025
@jongiddy
Copy link
Contributor Author

Yes, I think this forces us to raise the MSRV to 1.67. That's well within the specified support. Probably worth a minor bump on the next release though.

@joshtriplett
Copy link
Member

@jongiddy Please go ahead and raise the MSRV in Cargo.toml to match. (I don't think it needs a minor bump.)

@jongiddy jongiddy force-pushed the update-min-compiler branch from 92b00a4 to 3c299bd Compare February 11, 2025 19:45
@joshtriplett joshtriplett merged commit 2d68455 into rust-lang:main Feb 11, 2025
14 checks passed
@Byron Byron removed the question label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants