Fix low contrast on downloads graph labels and borders #8679
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8675
Unfortunately Chart.js does not natively support any kind of dark mode switching (see chartjs/Chart.js#9214), so we have to implement it ourselves.
The first commit adds a
resolvedScheme
property to thecolorScheme
service, which is automatically updated when either the user explicitly switches the color scheme, or the user is on the "System" setting and the OS decides that it's time for a color scheme change.The second commit then uses
{{did-update ...}}
to adjust the Chart.js settings and runchart.update()
when theresolvedScheme
property changes.Light
Dark (before)
Dark (after)