Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using feature "libc/std" #860

Merged
merged 1 commit into from Aug 20, 2023
Merged

Stop using feature "libc/std" #860

merged 1 commit into from Aug 20, 2023

Conversation

kadiwa4
Copy link
Contributor

@kadiwa4 kadiwa4 commented Aug 20, 2023

Fixes #852. When using the old cargo tree resolver and writing no_std code which depends on libc, updating to 1.0.80 breaks your code.

Edit: I realised that that's not quite how it works; libc is pretty much always #![no_std], but with libc/std enabled it links against some system libraries.

Copy link
Member

@thomcc thomcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@thomcc thomcc merged commit d8a653b into rust-lang:main Aug 20, 2023
16 checks passed
@thomcc
Copy link
Member

thomcc commented Aug 20, 2023

If you make a PR updating the version to 1.0.83, I'll merge and cut a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build problems in rust-secp256k1 after #780
2 participants