Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detect_compiler_family.c not being created #1072

Merged
merged 4 commits into from
May 19, 2024

Conversation

Jake-Shadle
Copy link
Contributor

This fixes an issue where the detect_compiler_family.c temp file would not be created, thus falling back to defaults, printing a warning, eg warning: libz-sys@1.1.18: Compiler family detection failed due to error: IOError: No such file or directory (os error 2). I noticed this when debugging a cargo package command, as I believe that is an edge case due to how it differs from a normal cargo build.

src/tool.rs Outdated Show resolved Hide resolved
src/tool.rs Outdated Show resolved Hide resolved
Jake-Shadle and others added 2 commits May 18, 2024 11:16
Co-authored-by: Jiahao XU <Jiahao_XU@outlook.com>
Co-authored-by: Jiahao XU <Jiahao_XU@outlook.com>
Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

You just need a cargo fmt before I can merge and release this!

Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@NobodyXu NobodyXu merged commit 8f6d07f into rust-lang:main May 19, 2024
24 checks passed
bugwelle pushed a commit to cap-js-community/tree-sitter-cds that referenced this pull request May 27, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence | Type |
Update |
|---|---|---|---|---|---|---|---|
| [@eslint/js](https://eslint.org)
([source](https://togithub.com/eslint/eslint/tree/HEAD/packages/js)) |
[`9.2.0` ->
`9.3.0`](https://renovatebot.com/diffs/npm/@eslint%2fjs/9.2.0/9.3.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/@eslint%2fjs/9.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@eslint%2fjs/9.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@eslint%2fjs/9.2.0/9.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@eslint%2fjs/9.2.0/9.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| devDependencies | minor |
| [cc](https://togithub.com/rust-lang/cc-rs) | `1.0.97` -> `1.0.98` |
[![age](https://developer.mend.io/api/mc/badges/age/crate/cc/1.0.98?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/crate/cc/1.0.98?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/crate/cc/1.0.97/1.0.98?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/crate/cc/1.0.97/1.0.98?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| build-dependencies | patch |
| [eslint](https://eslint.org)
([source](https://togithub.com/eslint/eslint)) | [`9.2.0` ->
`9.3.0`](https://renovatebot.com/diffs/npm/eslint/9.2.0/9.3.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/eslint/9.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/eslint/9.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/eslint/9.2.0/9.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/eslint/9.2.0/9.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| devDependencies | minor |

---

### Release Notes

<details>
<summary>eslint/eslint (@&#8203;eslint/js)</summary>

### [`v9.3.0`](https://togithub.com/eslint/eslint/releases/tag/v9.3.0)

[Compare
Source](https://togithub.com/eslint/eslint/compare/v9.2.0...v9.3.0)

#### Features

-
[`b32153c`](https://togithub.com/eslint/eslint/commit/b32153c97317c6fc593c2abbf6ae994519d473b4)
feat: add `overrides.namedExports` to `func-style` rule
([#&#8203;18444](https://togithub.com/eslint/eslint/issues/18444))
(Percy Ma)
-
[`b67eba4`](https://togithub.com/eslint/eslint/commit/b67eba4514026ef7e489798fd883beb678817a46)
feat: add `restrictedNamedExportsPattern` to `no-restricted-exports`
([#&#8203;18431](https://togithub.com/eslint/eslint/issues/18431)) (Akul
Srivastava)
-
[`069aa68`](https://togithub.com/eslint/eslint/commit/069aa680c78b8516b9a1b568519f1d01e74fb2a2)
feat: add option `allowEscape` to `no-misleading-character-class` rule
([#&#8203;18208](https://togithub.com/eslint/eslint/issues/18208))
(Francesco Trotta)
-
[`05ef92d`](https://togithub.com/eslint/eslint/commit/05ef92dd15949014c0735125c89b7bd70dec58c8)
feat: deprecate `multiline-comment-style` & `line-comment-position`
([#&#8203;18435](https://togithub.com/eslint/eslint/issues/18435)) (唯然)
-
[`db0b174`](https://togithub.com/eslint/eslint/commit/db0b174c3ace60e29585bfc3520727c44cefcfc5)
feat: add `enforceForInnerExpressions` option to `no-extra-boolean-cast`
([#&#8203;18222](https://togithub.com/eslint/eslint/issues/18222)) (Kirk
Waiblinger)

#### Bug Fixes

-
[`8db0eff`](https://togithub.com/eslint/eslint/commit/8db0eff4ba89b45f439c27ba1202ed056ae92e83)
fix: Improve config error messages
([#&#8203;18457](https://togithub.com/eslint/eslint/issues/18457))
(Nicholas C. Zakas)
-
[`5c28d9a`](https://togithub.com/eslint/eslint/commit/5c28d9a367e1608e097c491f40b8afd0730a8b9e)
fix: don't remove comments between key and value in object-shorthand
([#&#8203;18442](https://togithub.com/eslint/eslint/issues/18442)) (Kuba
Jastrzębski)
-
[`39fb0ee`](https://togithub.com/eslint/eslint/commit/39fb0ee9cd33f952707294e67f194d414261a571)
fix: object-shorthand loses type parameters when auto-fixing
([#&#8203;18438](https://togithub.com/eslint/eslint/issues/18438))
(dalaoshu)
-
[`37eba48`](https://togithub.com/eslint/eslint/commit/37eba48d6f2d3c99c5ecf2fc3967e428a6051dbb)
fix: don't crash when `fs.readFile` returns promise from another realm
([#&#8203;18416](https://togithub.com/eslint/eslint/issues/18416))
(Milos Djermanovic)

#### Documentation

-
[`ceada8c`](https://togithub.com/eslint/eslint/commit/ceada8c702d4903d6872f46a25d68b672d2c6289)
docs: explain how to use "tsc waiting" label
([#&#8203;18466](https://togithub.com/eslint/eslint/issues/18466))
(Francesco Trotta)
-
[`62e686c`](https://togithub.com/eslint/eslint/commit/62e686c5e90411fed2b5561be5688d7faf64d791)
docs: Add troubleshooting info for plugin compatibility
([#&#8203;18451](https://togithub.com/eslint/eslint/issues/18451))
(Nicholas C. Zakas)
-
[`e17e1c0`](https://togithub.com/eslint/eslint/commit/e17e1c0dd5d5dc5a4cae5888116913f6555b1f1e)
docs: Update README (GitHub Actions Bot)
-
[`2465a1e`](https://togithub.com/eslint/eslint/commit/2465a1e3f3b78f302f64e62e5f0d851626b81b3c)
docs: Update README (GitHub Actions Bot)
-
[`d23574c`](https://togithub.com/eslint/eslint/commit/d23574c5c0275c8b3714a7a6d3e8bf2108af60f1)
docs: Clarify usage of `no-unreachable` with TypeScript
([#&#8203;18445](https://togithub.com/eslint/eslint/issues/18445))
(benj-dobs)
-
[`1db9bae`](https://togithub.com/eslint/eslint/commit/1db9bae944b69945e3b05f76754cced16ae83838)
docs: Fix typos
([#&#8203;18443](https://togithub.com/eslint/eslint/issues/18443))
(Frieder Bluemle)
-
[`7065196`](https://togithub.com/eslint/eslint/commit/70651968beb0f907c9689c2477721c0b991acc4a)
docs: Update README (GitHub Actions Bot)
-
[`04e7c6e`](https://togithub.com/eslint/eslint/commit/04e7c6e0a24bd2d7691ae641e2dc0e6d538dcdfd)
docs: update deprecation notice of `no-return-await`
([#&#8203;18433](https://togithub.com/eslint/eslint/issues/18433))
(Tanuj Kanti)
-
[`e763512`](https://togithub.com/eslint/eslint/commit/e7635126f36145b47fe5d135ab258af43b2715c9)
docs: Link global ignores section in config object property list
([#&#8203;18430](https://togithub.com/eslint/eslint/issues/18430))
(MaoShizhong)
-
[`ac7f718`](https://togithub.com/eslint/eslint/commit/ac7f718de66131187302387fc26907c4c93196f9)
docs: reflect release of v9 in config migration guide
([#&#8203;18412](https://togithub.com/eslint/eslint/issues/18412))
(Peter Briggs)
-
[`0de0909`](https://togithub.com/eslint/eslint/commit/0de0909e001191a3464077d37e8c0b3f67e9a1cb)
docs: fix grammar in configuration file resolution
([#&#8203;18419](https://togithub.com/eslint/eslint/issues/18419)) (Mike
McCready)

#### Chores

-
[`58e2719`](https://togithub.com/eslint/eslint/commit/58e271924aeb8ac2b8864845cd787ef3f9239939)
chore: update dependencies for v9.3.0 release
([#&#8203;18469](https://togithub.com/eslint/eslint/issues/18469))
(Francesco Trotta)
-
[`b681ecb`](https://togithub.com/eslint/eslint/commit/b681ecbdf0882cbb7902682a9d35c1e76ac76c30)
chore: package.json update for
[@&#8203;eslint/js](https://togithub.com/eslint/js) release (Jenkins)
-
[`06f1d1c`](https://togithub.com/eslint/eslint/commit/06f1d1cd874dfc40a6651b08d766f6522a67b3f0)
chore: update dependency
[@&#8203;humanwhocodes/retry](https://togithub.com/humanwhocodes/retry)
to ^0.3.0
([#&#8203;18463](https://togithub.com/eslint/eslint/issues/18463))
(renovate\[bot])
-
[`a63ed72`](https://togithub.com/eslint/eslint/commit/a63ed722a64040d2be90f36e45f1f5060a9fe28e)
refactor: Use `node:` protocol for built-in Node.js modules
([#&#8203;18434](https://togithub.com/eslint/eslint/issues/18434))
(Milos Djermanovic)
-
[`040700a`](https://togithub.com/eslint/eslint/commit/040700a7a19726bb9568fc190bff95e88fb87269)
chore: update dependency markdownlint-cli to ^0.40.0
([#&#8203;18425](https://togithub.com/eslint/eslint/issues/18425))
(renovate\[bot])
-
[`f47847c`](https://togithub.com/eslint/eslint/commit/f47847c1b45ef1ac5f05f3a37f5f8c46b860c57f)
chore: update actions/stale action to v9
([#&#8203;18426](https://togithub.com/eslint/eslint/issues/18426))
(renovate\[bot])
-
[`c18ad25`](https://togithub.com/eslint/eslint/commit/c18ad252c280443e85f788c70ce597e1941f8ff5)
chore: update actions/upload-artifact action to v4
([#&#8203;18427](https://togithub.com/eslint/eslint/issues/18427))
(renovate\[bot])
-
[`27e3060`](https://togithub.com/eslint/eslint/commit/27e3060f7519d84501a11218343c34df4947b303)
chore: Disable documentation label
([#&#8203;18423](https://togithub.com/eslint/eslint/issues/18423))
(Nicholas C. Zakas)

</details>

<details>
<summary>rust-lang/cc-rs (cc)</summary>

###
[`v1.0.98`](https://togithub.com/rust-lang/cc-rs/releases/tag/1.0.98)

[Compare
Source](https://togithub.com/rust-lang/cc-rs/compare/1.0.97...1.0.98)

#### What's Changed

- Cleanup some deprecated, unused allows by
[@&#8203;klensy](https://togithub.com/klensy) in
[rust-lang/cc-rs#1067
- Fix paths on Mac Catalyst by
[@&#8203;madsmtm](https://togithub.com/madsmtm) in
[rust-lang/cc-rs#1070
- Fix detect_compiler_family.c not being created by
[@&#8203;Jake-Shadle](https://togithub.com/Jake-Shadle) in
[rust-lang/cc-rs#1072
- Release cc 1.0.98 by [@&#8203;NobodyXu](https://togithub.com/NobodyXu)
in
[rust-lang/cc-rs#1073

#### New Contributors

- [@&#8203;klensy](https://togithub.com/klensy) made their first
contribution in
[rust-lang/cc-rs#1067

**Full Changelog**:
rust-lang/cc-rs@1.0.97...1.0.98

</details>

<details>
<summary>eslint/eslint (eslint)</summary>

###
[`v9.3.0`](https://togithub.com/eslint/eslint/compare/v9.2.0...41a871cf43874e2f27ad08554c7900daf0e94b06)

[Compare
Source](https://togithub.com/eslint/eslint/compare/v9.2.0...v9.3.0)

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants