-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(toml): Convert warnings that licence
and readme
files do not exist into errors
#13921
Conversation
493e0f4
to
5c35e29
Compare
@bors try |
fix(toml): Convert warnings that `licence` and `readme` files do not exist into errors ### What does this PR try to resolve? In this PR: - Changed the warning to a hard error and modified the associated test function; - Removed what should have been a redundant test function:`publish::publish_with_missing_readme`; - Since `cargo publish` is preceded by the execution of `cargo package`, the error message in the test `function bad_license_file` needs to be modified. issue: #13629 (comment). ### Additional information It seems that this is not enough, the current situation is that `cargo package` warns if `package.readme` is an empty string or the wrong file location, but if I cancel `package.readme`, no warning is generated. I'm wondering if I should judge `package.readme&licence` when executing `cargo package` and return an error if it doesn't exist? As this has not been done before, your advice is sought.
💔 Test failed - checks-actions |
@bors try |
fix(toml): Convert warnings that `licence` and `readme` files do not exist into errors ### What does this PR try to resolve? In this PR: - Changed the warning to a hard error and modified the associated test function; - Removed what should have been a redundant test function:`publish::publish_with_missing_readme`; - Since `cargo publish` is preceded by the execution of `cargo package`, the error message in the test `function bad_license_file` needs to be modified. issue: #13629 (comment). ### Additional information It seems that this is not enough, the current situation is that `cargo package` warns if `package.readme` is an empty string or the wrong file location, but if I cancel `package.readme`, no warning is generated. I'm wondering if I should judge `package.readme&licence` when executing `cargo package` and return an error if it doesn't exist? As this has not been done before, your advice is sought.
☀️ Try build successful - checks-actions |
54e7613
to
d780220
Compare
d780220
to
193319c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Also schedule this to merge after 1.81 nightly comes out.
@bors r+ |
☀️ Test successful - checks-actions |
What does this PR try to resolve?
In this PR:
publish::publish_with_missing_readme
;cargo publish
is preceded by the execution ofcargo package
, the error message in the testfunction bad_license_file
needs to be modified.issue: #13629 (comment).
Additional information
It seems that this is not enough, the current situation is that
cargo package
warns ifpackage.readme
is an empty string or the wrong file location, but if I cancelpackage.readme
, no warning is generated.I'm wondering if I should judge
package.readme&licence
when executingcargo package
and return an error if it doesn't exist?As this has not been done before, your advice is sought.