fix(toml): remove lib.plugin key support and make it warning
#13902
+37
−466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-manifest
13 tasks
heisen-li
force-pushed
the
plugin
branch
2 times, most recently
from
feda71e
to
3638496
Compare
weihanglo
reviewed
May 13, 2024
There was a problem hiding this comment.
Could you do documentation update as well?
src/doc/src/reference/cargo-targets.mdcould just indicate that “This option is deprecated and unused”.- Change this line to “mostly for support of proc-macros”.
- Any other comments or function names containing "plugin" that needs to be removed. You can hold of this a bit, as it might require extra efforts.
Personally the change is fine, though I still think it is great to ship this along with the version introduction edition 2024 (not tie to edition just merge this in the same version).
weihanglo
reviewed
May 15, 2024
weihanglo
reviewed
May 16, 2024
weihanglo
approved these changes
May 20, 2024
|
@bors try |
bors
added a commit
that referenced
this pull request
Jun 9, 2024
fix(toml): remove `lib.plugin` key support and make it warning ### What does this PR try to resolve? Remove `lib.plugin` key, making it an "unused key" warning. Remove some of the tests, which should look useless (I hope I'm understanding this - [x] Remove key, and related tests. - [x] Adjust the documentation about the plugin. - [ ] Some of the comments and function names have not yet finished being modified. part of #13629 Closes #13246
|
☀️ Try build successful - checks-actions |
|
@bors r+ Thanks! |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Something was off about the timing of this and CI is now reporting a breaking change. We need to bump the version of See https://github.com/rust-lang/cargo/actions/runs/9449610811/job/26026286907?pr=14037 |
epage
added a commit
to epage/cargo
that referenced
this pull request
Jun 10, 2024
bors
added a commit
that referenced
this pull request
Jun 10, 2024
chore: Bump cargo-util-schemas to 0.5 See #13902
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR try to resolve?
Remove
lib.pluginkey, making it an "unused key" warning.Remove some of the tests, which should look useless (I hope I'm understanding this
part of #13629
Closes #13246