Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better suggestion for unsupported --path flag #12811

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

hi-rustin
Copy link
Member

What does this PR try to resolve?

close #11702

Added a better suggestion for the unsupported --path flag.

How should we test and review this PR?

Check out the unit tests.

Additional information

r? @weihanglo

Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@rustbot rustbot added A-cli Area: Command-line interface, option parsing, etc. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2023
@weihanglo weihanglo changed the title Better suggestion for unsupported -path flag Better suggestion for unsupported --path flag Oct 12, 2023
@hi-rustin hi-rustin marked this pull request as draft October 12, 2023 01:52
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
Signed-off-by: hi-rustin <rustin.liu@gmail.com>
@hi-rustin hi-rustin marked this pull request as ready for review October 12, 2023 11:46
@epage
Copy link
Contributor

epage commented Oct 12, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 12, 2023

📌 Commit ded92b1 has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2023
@bors
Copy link
Collaborator

bors commented Oct 12, 2023

⌛ Testing commit ded92b1 with merge 0d3f77f...

@bors
Copy link
Collaborator

bors commented Oct 12, 2023

☀️ Test successful - checks-actions
Approved by: epage
Pushing 0d3f77f to master...

@bors bors merged commit 0d3f77f into rust-lang:master Oct 12, 2023
20 checks passed
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 17, 2023
Update cargo

17 commits in 6fa6fdc7606cfa664f9bee2fb33ee2ed904f4e88..ff768b45b302efd488178b31b35489e4fabb8799
2023-10-10 23:06:08 +0000 to 2023-10-17 12:51:31 +0000
- Clarify flag behavior in `cargo remove --help` (rust-lang/cargo#12823)
- doc(cargo-login): mention args after `--` in manpage (rust-lang/cargo#12832)
- changelog: add compat notice for `cargo login -- &lt;arg&gt;` (rust-lang/cargo#12830)
- update SPDX License info (rust-lang/cargo#12827)
- Add test for `-V` short argument (rust-lang/cargo#12822)
- add detailed message when target folder path is invalid (rust-lang/cargo#12820)
- chore(deps): update rust crate toml_edit to 0.20.2 (rust-lang/cargo#12761)
- Support `public` dependency configuration with workspace deps (rust-lang/cargo#12817)
- Update rustix to 0.38.18 (rust-lang/cargo#12815)
- contrib docs: add some conveniences (rust-lang/cargo#12812)
- Better suggestion for unsupported `--path` flag (rust-lang/cargo#12811)
- contrib docs: update rfc and roadmap links (rust-lang/cargo#12814)
- contrib doc: remove extraneous word (rust-lang/cargo#12813)
- Update curl-sys to pull in curl 8.4.0 (rust-lang/cargo#12808)
- feat: add package name and version to warning messages (rust-lang/cargo#12799)
- Do not call it "Downgrading" when difference is only build metadata (rust-lang/cargo#12796)
- Add unsupported short flag suggestion for `--target` and `--exclude` flags (rust-lang/cargo#12805)

r? ghost
@ehuss ehuss added this to the 1.75.0 milestone Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Area: Command-line interface, option parsing, etc. Command-add S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cargo should give helpful errors when unsupported flags are used.
6 participants