Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unsupported short suggestion for --out-dir flag #12755

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Add unsupported short suggestion for --out-dir flag #12755

merged 2 commits into from
Oct 4, 2023

Conversation

hi-rustin
Copy link
Member

@hi-rustin hi-rustin commented Sep 30, 2023 •
edited

What does this PR try to resolve?

ref #11702

Added unsupported short alias suggestion for --out-dir flag.

How should we test and review this PR?

See the unit test.

Additional information

I am not sure if error: unexpected argument '--unsupported-short-out-dir-flag' found makes sense.

I don't know how to make it show error: unexpected argument '-O'

@rustbot
Copy link
Collaborator

rustbot commented Sep 30, 2023

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-cli Area: Command-line interface, option parsing, etc. Command-build S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2023
@hi-rustin
Copy link
Member Author

r? @weihanglo

Give it to weihang because he has reviewed other PRs.

@rustbot rustbot assigned weihanglo and unassigned ehuss Sep 30, 2023
@hi-rustin hi-rustin changed the title Add test for unsupported short out dir flag Add unsupported short suggestion for --out-dir flag Sep 30, 2023
@hi-rustin hi-rustin requested a review from epage October 4, 2023 04:40
weihanglo
weihanglo reviewed Oct 4, 2023
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one tiny bug, otherwise lgtm

src/cargo/util/command_prelude.rs Outdated Show resolved Hide resolved
weihanglo
weihanglo approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@weihanglo
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 4, 2023

📌 Commit 7bd0f81 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2023
@bors
Copy link
Collaborator

bors commented Oct 4, 2023

⌛ Testing commit 7bd0f81 with merge 3f9099b...

@bors
Copy link
Collaborator

bors commented Oct 4, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 3f9099b to master...

@bors bors merged commit 3f9099b into rust-lang:master Oct 4, 2023
20 checks passed
@hi-rustin
Copy link
Member Author

Thanks for your review! 💚 💙 💜 💛 ❤️

@weihanglo weihanglo mentioned this pull request Oct 6, 2023
Closed
10 tasks
@ehuss ehuss added this to the 1.75.0 milestone Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weihanglo weihanglo weihanglo approved these changes

@epage epage Awaiting requested review from epage

Assignees

@weihanglo weihanglo

Labels
A-cli Area: Command-line interface, option parsing, etc. Command-build S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.75.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hi-rustin @rustbot @weihanglo @bors @epage @ehuss