Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style: Add left margin for columns on all screen sizes #786

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rbuch
Copy link

@rbuch rbuch commented Feb 27, 2021

Previously, .column and .columns only had a margin-left of 4% when the viewport satisfied min-width:550px. On mobile, this led to the columns in the footer abutting each other with no space in between (see "Before" screenshot, in particular the "Contact the Rust Team" and "Licenses" lines). This change gives .column and .columns a left margin of 4% at all screen widths, giving the columns a bit of breathing room. Before and after screenshots are given below, as rendered by Firefox's Responsive Design Mode using the Pixel 2 template.

Before:
before

After:
after

@rbuch rbuch requested a review from a team as a code owner February 27, 2021 08:57
@camelid
Copy link
Member

camelid commented Feb 27, 2021

It seems we're not supposed to modify skeleton.css directly—see #683 (comment).

@rbuch
Copy link
Author

rbuch commented Mar 1, 2021

It seems we're not supposed to modify skeleton.css directly—see #683 (comment).

Ah, I see, thanks for pointing that out. It doesn't seem like your questions from that PR regarding where to put new CSS were ever answered, but do you know where new style changes should go? It seem like src/styles/app.scss has some overrides for Skeleton already, perhaps that's the place.

@rbuch
Copy link
Author

rbuch commented Mar 1, 2021

I've moved my change over to src/styles/app.scss rather than modifying skeleton.css directly, hopefully this is a better place for it.

@camelid
Copy link
Member

camelid commented Mar 2, 2021

It doesn't seem like your questions from that PR regarding where to put new CSS were ever answered, but do you know where new style changes should go?

Yeah, I don't know unfortunately.

I've moved my change over to src/styles/app.scss rather than modifying skeleton.css directly, hopefully this is a better place for it.

If that works out for you, I might try that in my own PR. Thanks :)

@rylev
Copy link
Member

rylev commented Jun 22, 2022

@rbuch sorry for letting this sit for so long. Is this just waiting for approval?

@rbuch
Copy link
Author

rbuch commented Jun 22, 2022

@rbuch sorry for letting this sit for so long. Is this just waiting for approval?

No worries. Yeah, it should be good to go, just needs approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants