Apply clippy::uninlined_format_args fixes #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where can I participate in this discussion of plans? |
workingjubilee
requested changes
Jun 21, 2023
There was a problem hiding this comment.
Thank you for your efforts. My apologies for it being so long to get around to this PR: this crate is fairly direly under-maintained. For that reason, currently this crate does not run clippy in CI, nor do I believe there is an intention to, as adding additional CI checks on getting code in is not what we want to be doing unless those are strictly necessary for functionality.
Normally I am inclined to approve a modest beautification PR like this, but I do not believe all of these changes are equally beautifying. Some make the code harder to read, by changing things so they are no longer read in a left-to-right manner, or in general complicating the code's overall style so that some of the results are surprising. If you wish to make additional changes to remove the diffs I have noted, or to improve the formatting code further until the concerns I have are eliminated, then I believe we could accept this. Otherwise, I will probably close this when I next make a pass over the PRs for this crate.
|
thx for great feedback, agree, will fix! |
nyurik
force-pushed
the
inline-fmt-arg
branch
2 times, most recently
from
a794c57
to
6cf1fa7
Compare
This was referenced Jul 2, 2023
Closed
|
@workingjubilee I addressed your feedback, and added a few more similar inlinings. To keep things cleaner, I think #539 should be merged first, possibly followed by #538 |
workingjubilee
force-pushed
the
inline-fmt-arg
branch
from
8345bab
to
6cf1fa7
Compare
workingjubilee
approved these changes
Aug 19, 2023
|
Below is the size of a hello-world Rust program linked with libstd with backtrace. Original binary size: 533976B |
* also did one minor spelling change in a print statement in `current-exe-mismatch.rs`
nyurik
force-pushed
the
inline-fmt-arg
branch
from
6cf1fa7
to
88629ea
Compare
|
@workingjubilee i rebased this PR to make sure it is up to date. Please review & merge unless there are some new issues. Thx! |
|
Code size changes for a hello-world Rust program linked with libstd with backtrace: On platform
|
kodiakhq bot
pushed a commit
to X-oss-byte/Canary-nextjs
that referenced
this pull request
May 1, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [backtrace](https://togithub.com/rust-lang/backtrace-rs) | dependencies | patch | `0.3` -> `0.3.71` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>rust-lang/backtrace-rs (backtrace)</summary> ### [`v0.3.71`](https://togithub.com/rust-lang/backtrace-rs/releases/tag/0.3.71) [Compare Source](https://togithub.com/rust-lang/backtrace-rs/compare/0.3.70...0.3.71) This is mostly CI changes, with a very mild bump to our effective cc crate version recorded, and a small modification to a previous changeset to allow backtrace to run at its current checked-in MSRV on Windows. Sorry about that! We will be getting 0.3.70 yanked shortly. ##### What's Changed - Make sgx functions exist with cfg(miri) by [@​saethlin](https://togithub.com/saethlin) in [rust-lang/backtrace-rs#591 - Update version of cc crate by [@​jfgoog](https://togithub.com/jfgoog) in [rust-lang/backtrace-rs#592 - Pull back MSRV on Windows by [@​workingjubilee](https://togithub.com/workingjubilee) in [rust-lang/backtrace-rs#598 - Force frame pointers on all i686 tests by [@​workingjubilee](https://togithub.com/workingjubilee) in [rust-lang/backtrace-rs#601 - Use rustc from stage0 instead of stage0-sysroot by [@​Nilstrieb](https://togithub.com/Nilstrieb) in [rust-lang/backtrace-rs#602 - Cut backtrace 0.3.71 by [@​workingjubilee](https://togithub.com/workingjubilee) in [rust-lang/backtrace-rs#599 ##### New Contributors - [@​jfgoog](https://togithub.com/jfgoog) made their first contribution in [rust-lang/backtrace-rs#592 - [@​Nilstrieb](https://togithub.com/Nilstrieb) made their first contribution in [rust-lang/backtrace-rs#602 **Full Changelog**: rust-lang/backtrace-rs@0.3.70...0.3.71 ### [`v0.3.70`](https://togithub.com/rust-lang/backtrace-rs/releases/tag/0.3.70) [Compare Source](https://togithub.com/rust-lang/backtrace-rs/compare/0.3.69...0.3.70) ##### New API - A `BacktraceFrame` can now have `resolve(&mut self)` called on it thanks to [@​fraillt](https://togithub.com/fraillt) in [rust-lang/backtrace-rs#526 ##### Platform Support We added support for new platforms in this release! - Thanks to [@​bzEq](https://togithub.com/bzEq) in [rust-lang/backtrace-rs#508 we now have AIX support! - Thanks to [@​sthibaul](https://togithub.com/sthibaul) in [rust-lang/backtrace-rs#567 we now have GNU/Hurd support! - Thanks to [@​dpaoliello](https://togithub.com/dpaoliello) in [rust-lang/backtrace-rs#587 we now support "emulation-compatible" AArch64 Windows (aka arm64ec) ##### Windows - Rewrite msvc backtrace support to be much faster on 64-bit platforms by [@​wesleywiser](https://togithub.com/wesleywiser) in [rust-lang/backtrace-rs#569 - Fix i686-pc-windows-gnu missing dbghelp module by [@​wesleywiser](https://togithub.com/wesleywiser) in [rust-lang/backtrace-rs#571 - Fix build errors on `thumbv7a-*-windows-msvc` targets by [@​kleisauke](https://togithub.com/kleisauke) in [rust-lang/backtrace-rs#573 - Fix panic in backtrace symbolication on win7 by [@​roblabla](https://togithub.com/roblabla) in [rust-lang/backtrace-rs#578 - remove few unused windows ffi fn by [@​klensy](https://togithub.com/klensy) in [rust-lang/backtrace-rs#576 - Make dbghelp look for PDBs next to their exe/dll. by [@​michaelwoerister](https://togithub.com/michaelwoerister) in [rust-lang/backtrace-rs#584 - Revert 32-bit dbghelp to a version WINE (presumably) likes by [@​ChrisDenton](https://togithub.com/ChrisDenton) in [rust-lang/backtrace-rs#588 - Update for Win10+ by [@​ChrisDenton](https://togithub.com/ChrisDenton) in [rust-lang/backtrace-rs#589 ##### SGX Thanks to - Adjust frame IP in SGX relative to image base by [@​mzohreva](https://togithub.com/mzohreva) in [rust-lang/backtrace-rs#566 ##### Internals We did a bunch more work on our CI and internal cleanups - Modularise CI workflow and validate outputs for binary size checks. by [@​detly](https://togithub.com/detly) in [rust-lang/backtrace-rs#549 - Commit Cargo.lock by [@​bjorn3](https://togithub.com/bjorn3) in [rust-lang/backtrace-rs#562 - Enable calling build.rs externally v2 by [@​pitaj](https://togithub.com/pitaj) in [rust-lang/backtrace-rs#568 - Upgrade to 2021 ed and inline panics by [@​nyurik](https://togithub.com/nyurik) in [rust-lang/backtrace-rs#538 - Fix deny(unused) of an unused import with SGX + Miri by [@​saethlin](https://togithub.com/saethlin) in [rust-lang/backtrace-rs#581 - Fix unused_imports warning on latest nightly by [@​ChrisDenton](https://togithub.com/ChrisDenton) in [rust-lang/backtrace-rs#575 - Fix CI by [@​saethlin](https://togithub.com/saethlin) in [rust-lang/backtrace-rs#582 - Use `addr_of!` by [@​GrigorenkoPV](https://togithub.com/GrigorenkoPV) in [rust-lang/backtrace-rs#585 - Write down MSRV policy by [@​workingjubilee](https://togithub.com/workingjubilee) in [rust-lang/backtrace-rs#561 - Apply clippy::uninlined_format_args fixes by [@​nyurik](https://togithub.com/nyurik) in [rust-lang/backtrace-rs#486 - ignore clippy lints in `symbolize/gimli/stash.rs` by [@​onur-ozkan](https://togithub.com/onur-ozkan) in [rust-lang/backtrace-rs#586 ##### New Contributors - [@​nyurik](https://togithub.com/nyurik) made their first contribution in [rust-lang/backtrace-rs#538 - [@​bzEq](https://togithub.com/bzEq) made their first contribution in [rust-lang/backtrace-rs#508 - [@​bjorn3](https://togithub.com/bjorn3) made their first contribution in [rust-lang/backtrace-rs#562 - [@​sthibaul](https://togithub.com/sthibaul) made their first contribution in [rust-lang/backtrace-rs#567 - [@​mzohreva](https://togithub.com/mzohreva) made their first contribution in [rust-lang/backtrace-rs#566 - [@​wesleywiser](https://togithub.com/wesleywiser) made their first contribution in [rust-lang/backtrace-rs#569 - [@​kleisauke](https://togithub.com/kleisauke) made their first contribution in [rust-lang/backtrace-rs#573 - [@​roblabla](https://togithub.com/roblabla) made their first contribution in [rust-lang/backtrace-rs#578 - [@​michaelwoerister](https://togithub.com/michaelwoerister) made their first contribution in [rust-lang/backtrace-rs#584 - [@​dpaoliello](https://togithub.com/dpaoliello) made their first contribution in [rust-lang/backtrace-rs#587 - [@​GrigorenkoPV](https://togithub.com/GrigorenkoPV) made their first contribution in [rust-lang/backtrace-rs#585 - [@​fraillt](https://togithub.com/fraillt) made their first contribution in [rust-lang/backtrace-rs#526 - [@​onur-ozkan](https://togithub.com/onur-ozkan) made their first contribution in [rust-lang/backtrace-rs#586 **Full Changelog**: rust-lang/backtrace-rs@0.3.69...0.3.70 ### [`v0.3.69`](https://togithub.com/rust-lang/backtrace-rs/releases/tag/0.3.69) [Compare Source](https://togithub.com/rust-lang/backtrace-rs/compare/0.3.68...0.3.69) Thank you everyone for contributing to a very nice release! ##### Tracking Binary Size As backtrace-rs is compiled into every single Rust program, we have begun tracking its binary size in order to find ways to reduce its impact on programs that only minimally use backtraces over time. This change is mostly relevant to this crate's CI, and has been implemented by [@​Kobzol](https://togithub.com/Kobzol) and [@​detly](https://togithub.com/detly) over PRs [#​542](https://togithub.com/rust-lang/backtrace-rs/issues/542), [#​544](https://togithub.com/rust-lang/backtrace-rs/issues/544), [#​546](https://togithub.com/rust-lang/backtrace-rs/issues/546), and [#​550](https://togithub.com/rust-lang/backtrace-rs/issues/550)! ##### Platform-Specific Fixes As usual, the majority of PRs for this release only affect 1 or 2 platforms. Technically, even the binary-size tracking is only implemented to track binary size on `x86_64-unknown-linux-gnu`. ##### fuchsia Backtraces for Fuchsia will now uses extended symbolization thanks to [@​liudangyi](https://togithub.com/liudangyi) in [rust-lang/backtrace-rs#559 ##### unix (with `procfs`) Many Unix-y platforms support `/proc`, including Linux and FreeBSD, but not OpenBSD. For those which do, backtrace uses `/proc/self/maps` to assist in recovering the trace. We did not parse the output of `/proc/self/maps` in a way that accounted for the fact that it may have spaces in path names, but this was fixed thanks to [@​MasonRemaley](https://togithub.com/MasonRemaley) in [rust-lang/backtrace-rs#553 ##### windows-msvc Some changes that should help binary size specifically on Windows MSVC targets, or at least compile times, have already been implemented, thanks to [@​klensy](https://togithub.com/klensy) in [rust-lang/backtrace-rs#543 omitting compiling-in ELF backtrace capabilities. We don't have full binary size tracking for all major supported operating systems yet, so we believe this is worth 30KiB but that's more of an estimate than hard stats. ##### Dependency Management - Update addr2line and object dependencies by [@​philipc](https://togithub.com/philipc) in [rust-lang/backtrace-rs#557 - Exclude ci directory from packaged crate by [@​mulkieran](https://togithub.com/mulkieran) in [rust-lang/backtrace-rs#555 - Enable calling build.rs directly from std/build.rs by [@​pitaj](https://togithub.com/pitaj) in [rust-lang/backtrace-rs#556 ##### New Contributors - [@​Kobzol](https://togithub.com/Kobzol) made their first contribution in [rust-lang/backtrace-rs#542 - [@​detly](https://togithub.com/detly) made their first contribution in [rust-lang/backtrace-rs#550 - [@​liudangyi](https://togithub.com/liudangyi) made their first contribution in [rust-lang/backtrace-rs#559 - [@​MasonRemaley](https://togithub.com/MasonRemaley) made their first contribution in [rust-lang/backtrace-rs#553 - [@​mulkieran](https://togithub.com/mulkieran) made their first contribution in [rust-lang/backtrace-rs#555 - [@​pitaj](https://togithub.com/pitaj) made their first contribution in [rust-lang/backtrace-rs#556 - [@​klensy](https://togithub.com/klensy) made their first contribution in [rust-lang/backtrace-rs#543 **Full Changelog**: rust-lang/backtrace-rs@0.3.68...0.3.69 ### [`v0.3.68`](https://togithub.com/rust-lang/backtrace-rs/releases/tag/0.3.68) [Compare Source](https://togithub.com/rust-lang/backtrace-rs/compare/0.3.67...0.3.68) A bunch of behind-the-scenes work on upgrading CI has finally got things to a place where we can do confident releases again, so hopefully the next backtrace version will not take 6 months! Thanks to everyone who contributed to that! Most of the user-facing changes are about dependency updates and consequent improved platform compatibility, including with split DWARF. A few new functions on BacktraceFmt should also make it easier to inject additional text into backtrace's output. - Adapt to new Fuchsia target name by [@​flba-eb](https://togithub.com/flba-eb) in [rust-lang/backtrace-rs#509 - armv7 PSVita OS support by [@​nikarh](https://togithub.com/nikarh) in [rust-lang/backtrace-rs#523 - Upgrade addr2line and properly handle split DWARF on Linux by [@​khuey](https://togithub.com/khuey) in [rust-lang/backtrace-rs#513 - deps: update miniz_oxide to 0.7 by [@​poliorcetics](https://togithub.com/poliorcetics) in [rust-lang/backtrace-rs#521 - Add print in BacktraceFmt by [@​chenyukang](https://togithub.com/chenyukang) in [rust-lang/backtrace-rs#527 - Bump object to 0.31 by [@​lnicola](https://togithub.com/lnicola) in [rust-lang/backtrace-rs#522 - Add an exception for QNX Neutrino 7.0 as a 'no-op' platform by [@​samkearney](https://togithub.com/samkearney) in [rust-lang/backtrace-rs#529 - Use mmap64 on Linux. by [@​mikebenfield](https://togithub.com/mikebenfield) in [rust-lang/backtrace-rs#501 - dbghlp: Make mutex name unique to the process by [@​ChrisDenton](https://togithub.com/ChrisDenton) in [rust-lang/backtrace-rs#518 - gimli add netbsd to handle dl_iterate_phdr as well. by [@​devnexen](https://togithub.com/devnexen) in [rust-lang/backtrace-rs#512 - Add other apple targets to libunwind workaround by [@​thomcc](https://togithub.com/thomcc) in [rust-lang/backtrace-rs#516 - Add fmt method for BacktraceFmt by [@​chenyukang](https://togithub.com/chenyukang) in [rust-lang/backtrace-rs#532 ##### New Contributors - [@​bwmf2](https://togithub.com/bwmf2) made their first contribution in [rust-lang/backtrace-rs#515 - [@​flba-eb](https://togithub.com/flba-eb) made their first contribution in [rust-lang/backtrace-rs#509 - [@​nikarh](https://togithub.com/nikarh) made their first contribution in [rust-lang/backtrace-rs#523 - [@​poliorcetics](https://togithub.com/poliorcetics) made their first contribution in [rust-lang/backtrace-rs#521 - [@​GuillaumeGomez](https://togithub.com/GuillaumeGomez) made their first contribution in [rust-lang/backtrace-rs#524 - [@​chenyukang](https://togithub.com/chenyukang) made their first contribution in [rust-lang/backtrace-rs#527 - [@​lnicola](https://togithub.com/lnicola) made their first contribution in [rust-lang/backtrace-rs#522 - [@​samkearney](https://togithub.com/samkearney) made their first contribution in [rust-lang/backtrace-rs#529 - [@​mikebenfield](https://togithub.com/mikebenfield) made their first contribution in [rust-lang/backtrace-rs#501 - [@​devnexen](https://togithub.com/devnexen) made their first contribution in [rust-lang/backtrace-rs#512 - [@​thomcc](https://togithub.com/thomcc) made their first contribution in [rust-lang/backtrace-rs#516 - [@​workingjubilee](https://togithub.com/workingjubilee) made their first contribution in [rust-lang/backtrace-rs#533 - [@​chriswailes](https://togithub.com/chriswailes) made their first contribution in [rust-lang/backtrace-rs#534 **Full Changelog**: rust-lang/backtrace-rs@0.3.67...0.3.68 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Canary-nextjs).
](https://renovatebot.com){kind=link}
kodiakhq bot
pushed a commit
to X-oss-byte/Nextjs
that referenced
this pull request
May 1, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [backtrace](https://togithub.com/rust-lang/backtrace-rs) | dependencies | patch | `0.3` -> `0.3.71` | --- ### Release Notes <details> <summary>rust-lang/backtrace-rs (backtrace)</summary> ### [`v0.3.71`](https://togithub.com/rust-lang/backtrace-rs/releases/tag/0.3.71) [Compare Source](https://togithub.com/rust-lang/backtrace-rs/compare/0.3.70...0.3.71) This is mostly CI changes, with a very mild bump to our effective cc crate version recorded, and a small modification to a previous changeset to allow backtrace to run at its current checked-in MSRV on Windows. Sorry about that! We will be getting 0.3.70 yanked shortly. ##### What's Changed - Make sgx functions exist with cfg(miri) by [@​saethlin](https://togithub.com/saethlin) in [rust-lang/backtrace-rs#591 - Update version of cc crate by [@​jfgoog](https://togithub.com/jfgoog) in [rust-lang/backtrace-rs#592 - Pull back MSRV on Windows by [@​workingjubilee](https://togithub.com/workingjubilee) in [rust-lang/backtrace-rs#598 - Force frame pointers on all i686 tests by [@​workingjubilee](https://togithub.com/workingjubilee) in [rust-lang/backtrace-rs#601 - Use rustc from stage0 instead of stage0-sysroot by [@​Nilstrieb](https://togithub.com/Nilstrieb) in [rust-lang/backtrace-rs#602 - Cut backtrace 0.3.71 by [@​workingjubilee](https://togithub.com/workingjubilee) in [rust-lang/backtrace-rs#599 ##### New Contributors - [@​jfgoog](https://togithub.com/jfgoog) made their first contribution in [rust-lang/backtrace-rs#592 - [@​Nilstrieb](https://togithub.com/Nilstrieb) made their first contribution in [rust-lang/backtrace-rs#602 **Full Changelog**: rust-lang/backtrace-rs@0.3.70...0.3.71 ### [`v0.3.70`](https://togithub.com/rust-lang/backtrace-rs/releases/tag/0.3.70) [Compare Source](https://togithub.com/rust-lang/backtrace-rs/compare/0.3.69...0.3.70) ##### New API - A `BacktraceFrame` can now have `resolve(&mut self)` called on it thanks to [@​fraillt](https://togithub.com/fraillt) in [rust-lang/backtrace-rs#526 ##### Platform Support We added support for new platforms in this release! - Thanks to [@​bzEq](https://togithub.com/bzEq) in [rust-lang/backtrace-rs#508 we now have AIX support! - Thanks to [@​sthibaul](https://togithub.com/sthibaul) in [rust-lang/backtrace-rs#567 we now have GNU/Hurd support! - Thanks to [@​dpaoliello](https://togithub.com/dpaoliello) in [rust-lang/backtrace-rs#587 we now support "emulation-compatible" AArch64 Windows (aka arm64ec) ##### Windows - Rewrite msvc backtrace support to be much faster on 64-bit platforms by [@​wesleywiser](https://togithub.com/wesleywiser) in [rust-lang/backtrace-rs#569 - Fix i686-pc-windows-gnu missing dbghelp module by [@​wesleywiser](https://togithub.com/wesleywiser) in [rust-lang/backtrace-rs#571 - Fix build errors on `thumbv7a-*-windows-msvc` targets by [@​kleisauke](https://togithub.com/kleisauke) in [rust-lang/backtrace-rs#573 - Fix panic in backtrace symbolication on win7 by [@​roblabla](https://togithub.com/roblabla) in [rust-lang/backtrace-rs#578 - remove few unused windows ffi fn by [@​klensy](https://togithub.com/klensy) in [rust-lang/backtrace-rs#576 - Make dbghelp look for PDBs next to their exe/dll. by [@​michaelwoerister](https://togithub.com/michaelwoerister) in [rust-lang/backtrace-rs#584 - Revert 32-bit dbghelp to a version WINE (presumably) likes by [@​ChrisDenton](https://togithub.com/ChrisDenton) in [rust-lang/backtrace-rs#588 - Update for Win10+ by [@​ChrisDenton](https://togithub.com/ChrisDenton) in [rust-lang/backtrace-rs#589 ##### SGX Thanks to - Adjust frame IP in SGX relative to image base by [@​mzohreva](https://togithub.com/mzohreva) in [rust-lang/backtrace-rs#566 ##### Internals We did a bunch more work on our CI and internal cleanups - Modularise CI workflow and validate outputs for binary size checks. by [@​detly](https://togithub.com/detly) in [rust-lang/backtrace-rs#549 - Commit Cargo.lock by [@​bjorn3](https://togithub.com/bjorn3) in [rust-lang/backtrace-rs#562 - Enable calling build.rs externally v2 by [@​pitaj](https://togithub.com/pitaj) in [rust-lang/backtrace-rs#568 - Upgrade to 2021 ed and inline panics by [@​nyurik](https://togithub.com/nyurik) in [rust-lang/backtrace-rs#538 - Fix deny(unused) of an unused import with SGX + Miri by [@​saethlin](https://togithub.com/saethlin) in [rust-lang/backtrace-rs#581 - Fix unused_imports warning on latest nightly by [@​ChrisDenton](https://togithub.com/ChrisDenton) in [rust-lang/backtrace-rs#575 - Fix CI by [@​saethlin](https://togithub.com/saethlin) in [rust-lang/backtrace-rs#582 - Use `addr_of!` by [@​GrigorenkoPV](https://togithub.com/GrigorenkoPV) in [rust-lang/backtrace-rs#585 - Write down MSRV policy by [@​workingjubilee](https://togithub.com/workingjubilee) in [rust-lang/backtrace-rs#561 - Apply clippy::uninlined_format_args fixes by [@​nyurik](https://togithub.com/nyurik) in [rust-lang/backtrace-rs#486 - ignore clippy lints in `symbolize/gimli/stash.rs` by [@​onur-ozkan](https://togithub.com/onur-ozkan) in [rust-lang/backtrace-rs#586 ##### New Contributors - [@​nyurik](https://togithub.com/nyurik) made their first contribution in [rust-lang/backtrace-rs#538 - [@​bzEq](https://togithub.com/bzEq) made their first contribution in [rust-lang/backtrace-rs#508 - [@​bjorn3](https://togithub.com/bjorn3) made their first contribution in [rust-lang/backtrace-rs#562 - [@​sthibaul](https://togithub.com/sthibaul) made their first contribution in [rust-lang/backtrace-rs#567 - [@​mzohreva](https://togithub.com/mzohreva) made their first contribution in [rust-lang/backtrace-rs#566 - [@​wesleywiser](https://togithub.com/wesleywiser) made their first contribution in [rust-lang/backtrace-rs#569 - [@​kleisauke](https://togithub.com/kleisauke) made their first contribution in [rust-lang/backtrace-rs#573 - [@​roblabla](https://togithub.com/roblabla) made their first contribution in [rust-lang/backtrace-rs#578 - [@​michaelwoerister](https://togithub.com/michaelwoerister) made their first contribution in [rust-lang/backtrace-rs#584 - [@​dpaoliello](https://togithub.com/dpaoliello) made their first contribution in [rust-lang/backtrace-rs#587 - [@​GrigorenkoPV](https://togithub.com/GrigorenkoPV) made their first contribution in [rust-lang/backtrace-rs#585 - [@​fraillt](https://togithub.com/fraillt) made their first contribution in [rust-lang/backtrace-rs#526 - [@​onur-ozkan](https://togithub.com/onur-ozkan) made their first contribution in [rust-lang/backtrace-rs#586 **Full Changelog**: rust-lang/backtrace-rs@0.3.69...0.3.70 ### [`v0.3.69`](https://togithub.com/rust-lang/backtrace-rs/releases/tag/0.3.69) [Compare Source](https://togithub.com/rust-lang/backtrace-rs/compare/0.3.68...0.3.69) Thank you everyone for contributing to a very nice release! ##### Tracking Binary Size As backtrace-rs is compiled into every single Rust program, we have begun tracking its binary size in order to find ways to reduce its impact on programs that only minimally use backtraces over time. This change is mostly relevant to this crate's CI, and has been implemented by [@​Kobzol](https://togithub.com/Kobzol) and [@​detly](https://togithub.com/detly) over PRs [#​542](https://togithub.com/rust-lang/backtrace-rs/issues/542), [#​544](https://togithub.com/rust-lang/backtrace-rs/issues/544), [#​546](https://togithub.com/rust-lang/backtrace-rs/issues/546), and [#​550](https://togithub.com/rust-lang/backtrace-rs/issues/550)! ##### Platform-Specific Fixes As usual, the majority of PRs for this release only affect 1 or 2 platforms. Technically, even the binary-size tracking is only implemented to track binary size on `x86_64-unknown-linux-gnu`. ##### fuchsia Backtraces for Fuchsia will now uses extended symbolization thanks to [@​liudangyi](https://togithub.com/liudangyi) in [rust-lang/backtrace-rs#559 ##### unix (with `procfs`) Many Unix-y platforms support `/proc`, including Linux and FreeBSD, but not OpenBSD. For those which do, backtrace uses `/proc/self/maps` to assist in recovering the trace. We did not parse the output of `/proc/self/maps` in a way that accounted for the fact that it may have spaces in path names, but this was fixed thanks to [@​MasonRemaley](https://togithub.com/MasonRemaley) in [rust-lang/backtrace-rs#553 ##### windows-msvc Some changes that should help binary size specifically on Windows MSVC targets, or at least compile times, have already been implemented, thanks to [@​klensy](https://togithub.com/klensy) in [rust-lang/backtrace-rs#543 omitting compiling-in ELF backtrace capabilities. We don't have full binary size tracking for all major supported operating systems yet, so we believe this is worth 30KiB but that's more of an estimate than hard stats. ##### Dependency Management - Update addr2line and object dependencies by [@​philipc](https://togithub.com/philipc) in [rust-lang/backtrace-rs#557 - Exclude ci directory from packaged crate by [@​mulkieran](https://togithub.com/mulkieran) in [rust-lang/backtrace-rs#555 - Enable calling build.rs directly from std/build.rs by [@​pitaj](https://togithub.com/pitaj) in [rust-lang/backtrace-rs#556 ##### New Contributors - [@​Kobzol](https://togithub.com/Kobzol) made their first contribution in [rust-lang/backtrace-rs#542 - [@​detly](https://togithub.com/detly) made their first contribution in [rust-lang/backtrace-rs#550 - [@​liudangyi](https://togithub.com/liudangyi) made their first contribution in [rust-lang/backtrace-rs#559 - [@​MasonRemaley](https://togithub.com/MasonRemaley) made their first contribution in [rust-lang/backtrace-rs#553 - [@​mulkieran](https://togithub.com/mulkieran) made their first contribution in [rust-lang/backtrace-rs#555 - [@​pitaj](https://togithub.com/pitaj) made their first contribution in [rust-lang/backtrace-rs#556 - [@​klensy](https://togithub.com/klensy) made their first contribution in [rust-lang/backtrace-rs#543 **Full Changelog**: rust-lang/backtrace-rs@0.3.68...0.3.69 ### [`v0.3.68`](https://togithub.com/rust-lang/backtrace-rs/releases/tag/0.3.68) [Compare Source](https://togithub.com/rust-lang/backtrace-rs/compare/0.3.67...0.3.68) A bunch of behind-the-scenes work on upgrading CI has finally got things to a place where we can do confident releases again, so hopefully the next backtrace version will not take 6 months! Thanks to everyone who contributed to that! Most of the user-facing changes are about dependency updates and consequent improved platform compatibility, including with split DWARF. A few new functions on BacktraceFmt should also make it easier to inject additional text into backtrace's output. - Adapt to new Fuchsia target name by [@​flba-eb](https://togithub.com/flba-eb) in [rust-lang/backtrace-rs#509 - armv7 PSVita OS support by [@​nikarh](https://togithub.com/nikarh) in [rust-lang/backtrace-rs#523 - Upgrade addr2line and properly handle split DWARF on Linux by [@​khuey](https://togithub.com/khuey) in [rust-lang/backtrace-rs#513 - deps: update miniz_oxide to 0.7 by [@​poliorcetics](https://togithub.com/poliorcetics) in [rust-lang/backtrace-rs#521 - Add print in BacktraceFmt by [@​chenyukang](https://togithub.com/chenyukang) in [rust-lang/backtrace-rs#527 - Bump object to 0.31 by [@​lnicola](https://togithub.com/lnicola) in [rust-lang/backtrace-rs#522 - Add an exception for QNX Neutrino 7.0 as a 'no-op' platform by [@​samkearney](https://togithub.com/samkearney) in [rust-lang/backtrace-rs#529 - Use mmap64 on Linux. by [@​mikebenfield](https://togithub.com/mikebenfield) in [rust-lang/backtrace-rs#501 - dbghlp: Make mutex name unique to the process by [@​ChrisDenton](https://togithub.com/ChrisDenton) in [rust-lang/backtrace-rs#518 - gimli add netbsd to handle dl_iterate_phdr as well. by [@​devnexen](https://togithub.com/devnexen) in [rust-lang/backtrace-rs#512 - Add other apple targets to libunwind workaround by [@​thomcc](https://togithub.com/thomcc) in [rust-lang/backtrace-rs#516 - Add fmt method for BacktraceFmt by [@​chenyukang](https://togithub.com/chenyukang) in [rust-lang/backtrace-rs#532 ##### New Contributors - [@​bwmf2](https://togithub.com/bwmf2) made their first contribution in [rust-lang/backtrace-rs#515 - [@​flba-eb](https://togithub.com/flba-eb) made their first contribution in [rust-lang/backtrace-rs#509 - [@​nikarh](https://togithub.com/nikarh) made their first contribution in [rust-lang/backtrace-rs#523 - [@​poliorcetics](https://togithub.com/poliorcetics) made their first contribution in [rust-lang/backtrace-rs#521 - [@​GuillaumeGomez](https://togithub.com/GuillaumeGomez) made their first contribution in [rust-lang/backtrace-rs#524 - [@​chenyukang](https://togithub.com/chenyukang) made their first contribution in [rust-lang/backtrace-rs#527 - [@​lnicola](https://togithub.com/lnicola) made their first contribution in [rust-lang/backtrace-rs#522 - [@​samkearney](https://togithub.com/samkearney) made their first contribution in [rust-lang/backtrace-rs#529 - [@​mikebenfield](https://togithub.com/mikebenfield) made their first contribution in [rust-lang/backtrace-rs#501 - [@​devnexen](https://togithub.com/devnexen) made their first contribution in [rust-lang/backtrace-rs#512 - [@​thomcc](https://togithub.com/thomcc) made their first contribution in [rust-lang/backtrace-rs#516 - [@​workingjubilee](https://togithub.com/workingjubilee) made their first contribution in [rust-lang/backtrace-rs#533 - [@​chriswailes](https://togithub.com/chriswailes) made their first contribution in [rust-lang/backtrace-rs#534 **Full Changelog**: rust-lang/backtrace-rs@0.3.67...0.3.68 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Nextjs).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the result of running
clippy::uninlined_format_argslint. Currently the lint is inpedantic, but there are plans/hopes to move it tostyle.How can I add this specific lint to the current build/CI tools, or is this not possible? It would be ideal not to make the lint as the default style and then end up with hundreds of changes in an unrelated PR due to CI requirements.
Locally, I ran this to generate the changes. Not ideal because it has produced a number of compilation errors.
Note that the MSRV must be at least 1.58 (which introduced inline format args)