Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitHub Actions #203

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Migrate to GitHub Actions #203

wants to merge 4 commits into from

Conversation

KodrAus
Copy link
Contributor

@KodrAus KodrAus commented Jun 3, 2022

No description provided.

@KodrAus
Copy link
Contributor Author

KodrAus commented Jun 3, 2022

While I'm here we should migrate those compile tests to trybuild 👀

@smoelius
Copy link

smoelius commented Jun 9, 2022

While I'm here we should migrate those compile tests to trybuild eyes

May I ask, what benefit would this provide? (This is a serious question, BTW.)

@KodrAus
Copy link
Contributor Author

KodrAus commented Jun 10, 2022

@smoelius There are two main ones I'm interested in:

  1. Not needing to set up a separate project to run compile tests, since they're what exercises most of the library. trybuild has a simpler API to work with.
  2. We might be able to get rid of some hacks we've accumulated to work around complexities in invoking Cargo the way these libraries do. We've had to shim lazy-static to make the old tests work because it's been a dependency of the compiler.

@smoelius
Copy link

Thanks, @KodrAus. I would be curious to see what those changes would look like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants