Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More specialization tests #799

Merged
merged 6 commits into from
Nov 13, 2023
Merged

More specialization tests #799

merged 6 commits into from
Nov 13, 2023

Commits on Nov 13, 2023

  1. Clonable TakeWhileInclusive

    @Philippe-Cholet
    Philippe-Cholet committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    b351f78 View commit details
    Browse the repository at this point in the history

  2. Clonable FilterMapOk

    @Philippe-Cholet
    Philippe-Cholet committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    788b63c View commit details
    Browse the repository at this point in the history

  3. Clonable Duplicates[By] 

    `private::{DuplicatesBy, Meta}` both derive `Clone` but it's not enough for `DuplicatesBy` and `Duplicates` to derive it as well, because `ById` and `ByFn` do not yet.
I think users are do not want to clone it as it would clone a `HashMap` and it would probably be slow.
However, I need that to add specialization tests.
    @Philippe-Cholet
    Philippe-Cholet committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    29a64ca View commit details
    Browse the repository at this point in the history

  4. New specialization tests 

    I do not want to add them one by one in future pull requests so this is done!
    @Philippe-Cholet
    Philippe-Cholet committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    4163a9e View commit details
    Browse the repository at this point in the history

  5. quickcheck: discard inputs rather than truncate them 

    For tests to not be slow, we sometimes need small enough inputs but I should not have truncated inputs previously.
Thanks to jswrenn, I now know that the right quickcheck-way is to discard some inputs (it then asks for other inputs).
    @Philippe-Cholet
    Philippe-Cholet committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    67b6c89 View commit details
    Browse the repository at this point in the history

  6. Test MultiProduct specializations

    @Philippe-Cholet
    Philippe-Cholet committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    62e11b0 View commit details
    Browse the repository at this point in the history