Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

combinations: count and size_hint #729

Merged
merged 14 commits into from
Aug 18, 2023
Merged

combinations: count and size_hint #729

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
80a22ac
`LazyBuffer::size_hint`
Philippe-Cholet Aug 16, 2023
d9f20e9
Checked binomial
Philippe-Cholet Aug 16, 2023
bd0b080
Remaining combinations for an unknown `n`
Philippe-Cholet Aug 16, 2023
76efb25
`LazyBuffer::fill`
Philippe-Cholet Aug 16, 2023
85c7980
`Combinations::count` tested
Philippe-Cholet Aug 16, 2023
ed998ba
`Combinations::size_hint`
Philippe-Cholet Aug 16, 2023
2ab0ff1
Remove `LazyBuffer::fill`, count instead
Philippe-Cholet Aug 16, 2023
1f48da7
`checked_binomial`: url algorithm
Philippe-Cholet Aug 18, 2023
95c3e27
remaining combinations: handle `n < k`
Philippe-Cholet Aug 18, 2023
da190e3
update `combinations_range_count` test
Philippe-Cholet Aug 18, 2023
baf6708
`Combinations::count`: unwrap instead of expect
Philippe-Cholet Aug 18, 2023
d8d4d61
`remaining_for`: add an explanation comment
Philippe-Cholet Aug 18, 2023
cfb2ec9
TODO: simplify when MSRV hits 1.37
Philippe-Cholet Aug 18, 2023
65e08d4
Test `checked_binomial`
Philippe-Cholet Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/lazy_buffer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ use std::iter::Fuse;
use std::ops::Index;
use alloc::vec::Vec;

use crate::size_hint::{self, SizeHint};

#[derive(Debug, Clone)]
pub struct LazyBuffer<I: Iterator> {
pub it: Fuse<I>,
Expand All @@ -23,6 +25,10 @@ where
self.buffer.len()
}

pub fn size_hint(&self) -> SizeHint {
size_hint::add_scalar(self.it.size_hint(), self.len())
Philippe-Cholet marked this conversation as resolved.
Show resolved Hide resolved
}

pub fn get_next(&mut self) -> bool {
if let Some(x) = self.it.next() {
self.buffer.push(x);
Expand Down