Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #657 #683

Merged
merged 3 commits into from Jun 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/groupbylazy.rs
Expand Up @@ -19,7 +19,7 @@ impl<A, K, F: ?Sized> KeyFunction<A> for F


/// `ChunkIndex` acts like the grouping key function for `IntoChunks`
#[derive(Debug)]
#[derive(Debug, Clone)]
struct ChunkIndex {
size: usize,
index: usize,
Expand Down Expand Up @@ -50,7 +50,7 @@ impl<A> KeyFunction<A> for ChunkIndex {
}
}


#[derive(Clone)]
struct GroupInner<K, I, F>
where I: Iterator
{
Expand Down Expand Up @@ -471,6 +471,13 @@ pub struct IntoChunks<I>
index: Cell<usize>,
}

impl<I> Clone for IntoChunks<I>
where I: Clone + Iterator,
I::Item: Clone,
{
clone_fields!(inner, index);
}


impl<I> IntoChunks<I>
where I: Iterator,
Expand Down Expand Up @@ -507,6 +514,7 @@ impl<'a, I> IntoIterator for &'a IntoChunks<I>
///
/// See [`.chunks()`](crate::Itertools::chunks) for more information.
#[must_use = "iterator adaptors are lazy and do nothing unless consumed"]
#[derive(Clone)]
pub struct Chunks<'a, I: 'a>
where I: Iterator,
I::Item: 'a,
Expand Down
11 changes: 11 additions & 0 deletions tests/quick.rs
Expand Up @@ -993,6 +993,17 @@ quickcheck! {
}
}

quickcheck! {
fn chunk_clone_equal(a: Vec<u8>, size: u8) -> () {
let mut size = size;
if size == 0 {
size += 1;
}
let it = a.chunks(size as usize);
itertools::assert_equal(it.clone(), it);
}
}

quickcheck! {
fn equal_chunks_lazy(a: Vec<u8>, size: u8) -> bool {
let mut size = size;
Expand Down