-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tuple_windows as lazy #602
Conversation
c7bf86a
to
25b1149
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've rebased and rustfmt'd this PR, but it's still failing a test. Can you fix the bug?
I deleted my previous comment, it was wrong (I must have been sleeping ^^). We would definitely need to update
EDIT: I was partially wrong, but real fix committed. |
Now that `TupleWindows` is lazy, we must adjust the size hint accordingly.
318dc95
to
e21c46a
Compare
@jswrenn This is ready for me, what do you think? |
Fix #601 anyway because this change will reduce one clone.