Fix #657 #683
Merged
Fix #657 #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jswrenn
requested changes
Mar 23, 2023
tests/test_std.rs
Outdated
Comment on lines
855
to
863
| for (i, chunk) in grouper_clone.into_iter().enumerate() { | ||
| match i { | ||
| 0 => it::assert_equal(chunk, &[0, 0, 0]), | ||
| 1 => it::assert_equal(chunk, &[1, 1, 0]), | ||
| 2 => it::assert_equal(chunk, &[0, 2, 2]), | ||
| 3 => it::assert_equal(chunk, &[3, 3]), | ||
| _ => unreachable!(), | ||
| } | ||
| } |
There was a problem hiding this comment.
Let's avoid the duplication here with the above code block, and make it more explicit that you're testing that these produce the same output.
You can achieve this by doing something like:
for (i, (chunk, cloned_chunk)) in grouper.into_iter(grouper_clone).zip().enumerate() {
assert_eq!(chunk, cloned_chunk);
match i { /* the match branches */ }
}There was a problem hiding this comment.
Fixed in d608283
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix seemed very simple. Maybe I'm missing something?
Fixes #657.